Skip to content

Commit 5b6995b

Browse files
authored
Adding explicit children props to components (PR #128)
* Adding explicit children props to components In React 18's types, the implicit children prop on functional components was removed, requiring that it be explicitly defined by developers; this change adds them to the library so that Typescript projects on React 18 can continue to import the library. * Also adding children to ContextMenuTriggerProps
1 parent ed4e809 commit 5b6995b

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/index.d.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ declare module "@firefox-devtools/react-contextmenu" {
1414
preventHideOnResize?: boolean,
1515
preventHideOnScroll?: boolean,
1616
style?: React.CSSProperties,
17+
children?: React.ReactNode,
1718
}
1819

1920
export interface ContextMenuTriggerProps {
@@ -25,7 +26,8 @@ declare module "@firefox-devtools/react-contextmenu" {
2526
renderTag?: React.ElementType,
2627
triggerOnLeftClick?: boolean,
2728
disableIfShiftIsPressed?: boolean,
28-
[key: string]: any
29+
[key: string]: any,
30+
children?: React.ReactNode,
2931
}
3032

3133
export interface MenuItemProps {
@@ -36,6 +38,7 @@ declare module "@firefox-devtools/react-contextmenu" {
3638
divider?: boolean,
3739
preventClose?: boolean,
3840
onClick?: {(event: React.TouchEvent<HTMLDivElement> | React.MouseEvent<HTMLDivElement>, data: Object, target: HTMLElement): void} | Function,
41+
children?: React.ReactNode,
3942
}
4043

4144
export interface SubMenuProps {
@@ -46,6 +49,7 @@ declare module "@firefox-devtools/react-contextmenu" {
4649
rtl?: boolean,
4750
preventCloseOnClick?: boolean,
4851
onClick?: {(event: React.TouchEvent<HTMLDivElement> | React.MouseEvent<HTMLDivElement>, data: Object, target: HTMLElement): void} | Function,
52+
children?: React.ReactNode,
4953
}
5054

5155
export interface ConnectMenuProps {

0 commit comments

Comments
 (0)