Merge pull request #610 from formio/FIO-9944-fix-forms-memory-leak

brendanbond · web-flow · commit b1c1a73429e4 · 2025-06-13T12:50:57.000-05:00
FIO-9944: Fixes an issue where some form instances will not be destroyed
diff --git a/src/components/Form.tsx b/src/components/Form.tsx
@@ -321,7 +321,12 @@ export const Form = (props: FormProps) => {
 				if (formReadyCallback) {
 					formReadyCallback(instance);
 				}
-				setFormInstance(instance);
+				setFormInstance((prevInstance: any) => {
+					if (prevInstance) {
+						prevInstance.destroy(true);
+					}
+					return instance;
+				});
 			} else {
 				console.warn('Failed to create form instance');
 			}

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,12 @@ export const Form = (props: FormProps) => {`
`321`	`321`	`if (formReadyCallback) {`
`322`	`322`	`formReadyCallback(instance);`
`323`	`323`	`}`
`324`		`- setFormInstance(instance);`
	`324`	`+ setFormInstance((prevInstance: any) => {`
	`325`	`+ if (prevInstance) {`
	`326`	`+ prevInstance.destroy(true);`
	`327`	`+ }`
	`328`	`+ return instance;`
	`329`	`+ });`
`325`	`330`	`} else {`
`326`	`331`	`console.warn('Failed to create form instance');`
`327`	`332`	`}`