Skip to content

Commit 2846577

Browse files
lczapnikgregkh
authored andcommitted
i40e: fix input validation logic for action_meta
commit 9739d58 upstream. Fix condition to check 'greater or equal' to prevent OOB dereference. Fixes: e284fc2 ("i40e: Add and delete cloud filter") Cc: stable@vger.kernel.org Signed-off-by: Lukasz Czapnik <lukasz.czapnik@intel.com> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6f15a7b commit 2846577

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3412,7 +3412,7 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf,
34123412

34133413
/* action_meta is TC number here to which the filter is applied */
34143414
if (!tc_filter->action_meta ||
3415-
tc_filter->action_meta > vf->num_tc) {
3415+
tc_filter->action_meta >= vf->num_tc) {
34163416
dev_info(&pf->pdev->dev, "VF %d: Invalid TC number %u\n",
34173417
vf->vf_id, tc_filter->action_meta);
34183418
goto err;

0 commit comments

Comments
 (0)