Skip to content

Commit 2b8f2af

Browse files
mszyprowgregkh
authored andcommitted
usb: dwc3: remove generic PHY calibrate() calls
[ Upstream commit a0a4655 ] Calls to USB2 generic PHY calibrate() method has been moved to HCD core, which now successfully handles generic PHYs and their calibration after every HCD reset. This fixes all the timing issues related to PHY calibration done directly from DWC3 driver: incorrect operation after system suspend/resume or USB3.0 detection failure when XHCI-plat driver compiled as separate module. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Tested-by: Anand Moon <linux.amoon@gmail.com> Tested-by: Jochen Sprickerhof <jochen@sprickerhof.de> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> Link: https://lore.kernel.org/r/20190829053028.32438-3-m.szyprowski@samsung.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Stable-dep-of: 0d410e8 ("usb: dwc3: core: Stop processing of pending events if controller is halted") Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent f313985 commit 2b8f2af

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/usb/dwc3/core.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ static void __dwc3_set_mode(struct work_struct *work)
167167
otg_set_vbus(dwc->usb2_phy->otg, true);
168168
phy_set_mode(dwc->usb2_generic_phy, PHY_MODE_USB_HOST);
169169
phy_set_mode(dwc->usb3_generic_phy, PHY_MODE_USB_HOST);
170-
phy_calibrate(dwc->usb2_generic_phy);
171170
}
172171
break;
173172
case DWC3_GCTL_PRTCAP_DEVICE:
@@ -1178,7 +1177,6 @@ static int dwc3_core_init_mode(struct dwc3 *dwc)
11781177
dev_err(dev, "failed to initialize host\n");
11791178
return ret;
11801179
}
1181-
phy_calibrate(dwc->usb2_generic_phy);
11821180
break;
11831181
case USB_DR_MODE_OTG:
11841182
INIT_WORK(&dwc->drd_work, __dwc3_set_mode);

0 commit comments

Comments
 (0)