Skip to content

Commit 731e676

Browse files
cristiccgregkh
authored andcommitted
ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks
[ Upstream commit 9cea742 ] Adding a memory barrier before wake_up() in snd_usb_soundblaster_remote_complete() is supposed to ensure the write to mixer->rc_code is visible in wait_event_interruptible() from snd_usb_sbrc_hwdep_read(). However, this is not really necessary, since wake_up() is just a wrapper over __wake_up() which already executes a full memory barrier before accessing the state of the task to be waken up. Drop the redundant call to wmb() and implicitly fix the checkpatch complaint: WARNING: memory barrier without comment Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-8-1a821463b632@collabora.com Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 7aa869f commit 731e676

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

sound/usb/mixer_quirks.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb)
207207
if (code == rc->mute_code)
208208
snd_usb_mixer_notify_id(mixer, rc->mute_mixer_id);
209209
mixer->rc_code = code;
210-
wmb();
211210
wake_up(&mixer->rc_waitq);
212211
}
213212

0 commit comments

Comments
 (0)