Skip to content

Commit 7f70f29

Browse files
test: rename SideEffect -> SideEffects in Concat, Delay, and Item tests
50+ test files already use the plural 'SideEffects' module name. Concat.Tests.fs, Delay.Tests.fs, and Item.Tests.fs were the only outliers still using the singular form 'SideEffect'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent fc687a3 commit 7f70f29

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

release-notes.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Release notes:
33

44
Unreleased
5+
- test: rename `SideEffect` module to `SideEffects` in TaskSeq.Concat.Tests.fs, TaskSeq.Delay.Tests.fs, and TaskSeq.Item.Tests.fs for consistency with the rest of the test suite (50+ files already use the plural form)
56
- test: add SideEffects module and ImmTaskSeq variant tests to TaskSeq.ChunkBy.Tests.fs, improving coverage for chunkBy and chunkByAsync
67
- fixes: `Async.bind` signature corrected from `(Async<'T> -> Async<'U>)` to `('T -> Async<'U>)` to match standard monadic bind semantics (same as `Task.bind`); the previous signature made the function effectively equivalent to direct application
78
- refactor: simplify splitAt 'rest' taskSeq to use while!, removing redundant go2 mutable and manual MoveNextAsync pre-advance

src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ module Immutable =
181181
|> consumeTaskSeq
182182
|> should throwAsyncExact typeof<NullReferenceException>
183183

184-
module SideEffect =
184+
module SideEffects =
185185
[<Fact>]
186186
let ``TaskSeq-concat executes side effects of nested (taskseq)`` () =
187187
let mutable i = 0

src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module Immutable =
3030
|> TaskSeq.delay
3131
|> validateSequence
3232

33-
module SideEffect =
33+
module SideEffects =
3434
[<Fact>]
3535
let ``TaskSeq-delay executes side effects`` () = task {
3636
let mutable i = 0

src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ module Immutable =
105105
tail |> should equal (Some 10)
106106
}
107107

108-
module SideEffect =
108+
module SideEffects =
109109
[<Theory; ClassData(typeof<TestSideEffectTaskSeq>)>]
110110
let ``TaskSeq-item prove it searches the whole sequence`` variant = task {
111111
let ts = Gen.getSeqWithSideEffect variant

0 commit comments

Comments
 (0)