Commit 93e172b
perf: reuse StringBuilder and ResizeArray in CSV parser to reduce per-field allocations
The readLine inner function previously built a reversed linked list of
field strings using cons (::), then called List.rev |> Array.ofList to
finalise each row. It also allocated a fresh StringBuilder for every
field separator encountered.
This commit replaces that with:
- A single shared StringBuilder (sb) captured in a closure, cleared
between fields instead of being re-created. This eliminates O(fields *
rows) StringBuilder allocations for large CSV files.
- A ResizeArray<string> accumulator per row, filled in forward order.
This replaces the reversed list + two-pass reversal with a single
O(n) ResizeArray.ToArray() call per row.
The readString helper is updated to append directly to the shared sb
rather than receiving/returning a builder argument.
All 2896 tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 77745ac commit 93e172b
2 files changed
Lines changed: 33 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
3 | 7 | | |
4 | 8 | | |
5 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
39 | 42 | | |
40 | | - | |
41 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
42 | 46 | | |
43 | | - | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | | - | |
47 | | - | |
48 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
49 | 56 | | |
50 | 57 | | |
51 | 58 | | |
52 | | - | |
| 59 | + | |
| 60 | + | |
53 | 61 | | |
54 | 62 | | |
55 | 63 | | |
56 | 64 | | |
57 | | - | |
58 | | - | |
| 65 | + | |
| 66 | + | |
59 | 67 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
64 | 77 | | |
65 | 78 | | |
66 | 79 | | |
| |||
70 | 83 | | |
71 | 84 | | |
72 | 85 | | |
73 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
74 | 89 | | |
75 | 90 | | |
76 | 91 | | |
| |||
0 commit comments