tiny memory optimisations

Author: Thorium

paket.lock

@@ -1501,7 +1501,7 @@ GITHUB
     src/ProvidedTypes.fs (ce34c1cc71096857b8342f1dedf93391addc9df6)
     src/ProvidedTypes.fsi (ce34c1cc71096857b8342f1dedf93391addc9df6)
   remote: Thorium/Linq.Expression.Optimizer
-    src/Code/ExpressionOptimizer.fs (5e1a0d610e6b8dd1e2347091c3b5e1fe694e1e3c)
+    src/Code/ExpressionOptimizer.fs (d89d2f7a8f04f268ad7b9ea3bc4279a9253edc66)
 GROUP Tests
 STORAGE: PACKAGES
 NUGET

src/SQLProvider.Common/SqlRuntime.Common.fs

@@ -361,34 +361,30 @@ type SqlEntity(dc: ISqlDataContext, tableName, columns: ColumnLookup, activeColu
         member __.SetColumnOptionSilent(key,value) =
           match value with
           | Some value ->
-              if data.ContainsKey key then
-                  data.[key] <- value
-              else data.Add(key,value)
+                data.[key] <- value
           | None -> data.Remove key |> ignore
 
         member __.SetPkColumnOptionSilent(keys,value) =
             match value with
             | Some value ->
                 keys |> List.iter(fun x -> 
-                    if data.ContainsKey x then data.[x] <- value
-                    else data.Add(x,value))
+                    data.[x] <- value
+                    )
             | None ->
                 keys |> List.iter(fun x -> data.Remove x |> ignore)
 
         member e.SetColumnOption(key,value) =
           match value with
           | Some value ->
-              if data.ContainsKey key then data.[key] <- value
-              else data.Add(key,value)
+              data.[key] <- value
               e.TriggerPropertyChange key
           | None -> if data.Remove key then e.TriggerPropertyChange key
           e.UpdateField key
 
         member e.SetColumnValueOption(key,value) =
           match value with
           | ValueSome value ->
-              if data.ContainsKey key then data.[key] <- value
-              else data.Add(key,value)
+              data.[key] <- value
               e.TriggerPropertyChange key
           | ValueNone -> if data.Remove key then e.TriggerPropertyChange key
           e.UpdateField key
@@ -1161,7 +1157,7 @@ module public OfflineTools =
                             match dummydata.TryGetValue(arg1.ToLower()) with
                             | true, tableData -> createMockEntitiesDc this arg1 tableData
                             | false, _ ->
-                                match dummydata |> Map.toSeq |> Seq.tryFind(fun (k,v) -> k.ToUpperInvariant() = arg1.ToUpperInvariant()) with
+                                match dummydata |> Map.toSeq |> Seq.tryFind(fun (k,v) -> String.Equals(k, arg1, StringComparison.InvariantCultureIgnoreCase)) with
                                 | Some (k, tableData) -> createMockEntitiesDc this arg1 tableData
                                 | None -> failwith ("Add table to dummydata: " + arg1) 
                     member this.CreateEntity(arg1: string): SqlEntity =

src/SQLProvider.Common/SqlRuntime.QueryExpression.fs

@@ -450,8 +450,10 @@ module internal QueryExpressionTransformer =
                                                                                          | false, _ -> projectionMap.Add(en, ResizeArray<_>())
                                                                                          upcast databaseParam
                                                                                     | _ ->
-                                                                                        if (not (isNull replaceParams)) && replaceParams.ContainsKey(e) then
-                                                                                            replaceParams.[e].Body
+                                                                                        if (not (isNull replaceParams)) then
+                                                                                            match replaceParams.TryGetValue e with
+                                                                                            | true, re -> re.Body
+                                                                                            | false, _ -> upcast e
                                                                                         else
                                                                                             upcast e
             | ExpressionType.MemberAccess,       (:? MemberExpression as e)      -> let memb = Expression.MakeMemberAccess(transform en e.Expression, e.Member)

src/SQLProvider.Common/Ssdt.DacpacParser.fs

@@ -325,7 +325,7 @@ let parseXml(xml: string) =
                 |> ValueOption.defaultValue "SQL_VARIANT"
             let allowNulls =
                 match annotation with
-                | ValueSome { Nullability = ValueSome nlb } -> nlb.ToUpperInvariant() = "NULL"
+                | ValueSome { Nullability = ValueSome nlb } -> String.Equals(nlb, "NULL", StringComparison.InvariantCultureIgnoreCase)
                 | ValueSome { Nullability = ValueNone } -> true // Sql Server column declarations allow nulls by default
                 | ValueNone -> false // Default to "SQL_VARIANT" (obj) with no nulls if annotation is not found
 
@@ -555,7 +555,7 @@ let parseXml(xml: string) =
                         |> Option.defaultValue "SQL_VARIANT"
                     let allowNulls =
                         match annotation with
-                        | Some { Nullability = ValueSome nlb } -> nlb.ToUpperInvariant() = "NULL"
+                        | Some { Nullability = ValueSome nlb } -> String.Equals(nlb, "NULL", StringComparison.InvariantCultureIgnoreCase)
                         | Some { Nullability = ValueNone } -> true // Sql Server column declarations allow nulls by default
                         | None -> false // Default to "SQL_VARIANT" (obj) with no nulls if annotation is not found
                     let description =