amstate: LastUnnoticedAlertsNotified() missed mutex

joonas-fi · joonas-fi · commit 2ac0016ffce2 · 2020-02-29T09:09:28.000+02:00
diff --git a/pkg/amstate/store.go b/pkg/amstate/store.go
@@ -115,6 +115,9 @@ func (s *Store) DeadMansSwitches() []DeadMansSwitch {
 }
 
 func (s *Store) LastUnnoticedAlertsNotified() time.Time {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
 	return s.state.LastUnnoticedAlertsNotified
 }
 

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,9 @@ func (s *Store) DeadMansSwitches() []DeadMansSwitch {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`func (s *Store) LastUnnoticedAlertsNotified() time.Time {`
	`118`	`+ s.mu.Lock()`
	`119`	`+ defer s.mu.Unlock()`
	`120`	`+`
`118`	`121`	`return s.state.LastUnnoticedAlertsNotified`
`119`	`122`	`}`
`120`	`123`