Skip to content

Commit 02c6a95

Browse files
feat: migrate database password from environment variable to Secret Manager for improved security
1 parent d290713 commit 02c6a95

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

cloudbuild.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,13 @@ steps:
2525
- '--no-allow-unauthenticated'
2626
- '--port=8080'
2727
- '--timeout=300'
28-
- '--set-env-vars=CLOUD_SQL_POSTGRES_PROJECT=$PROJECT_ID,CLOUD_SQL_POSTGRES_INSTANCE=omkar-demo-postgres-1,CLOUD_SQL_POSTGRES_REGION=us-central1,CLOUD_SQL_POSTGRES_DATABASE=postgres,CLOUD_SQL_POSTGRES_USER=postgres,CLOUD_SQL_POSTGRES_PASSWORD=[PASSWORD],CLOUD_SQL_POSTGRES_IP_TYPE=PUBLIC'
28+
- '--set-env-vars=CLOUD_SQL_POSTGRES_PROJECT=$PROJECT_ID,CLOUD_SQL_POSTGRES_INSTANCE=omkar-demo-postgres-1,CLOUD_SQL_POSTGRES_REGION=us-central1,CLOUD_SQL_POSTGRES_DATABASE=postgres,CLOUD_SQL_POSTGRES_USER=postgres,CLOUD_SQL_POSTGRES_IP_TYPE=PUBLIC'
29+
- '--set-secrets=CLOUD_SQL_POSTGRES_PASSWORD=cloud-sql-postgres-password:latest'
2930

3031
# --- STEP 3: Fully Integrated Evaluation to Persist Results ---
3132
- name: 'us-central1-docker.pkg.dev/$PROJECT_ID/toolbox-evals/eval_server:latest'
3233
entrypoint: 'bash'
34+
secretEnv: ['DB_PASSWORD']
3335
args:
3436
- '-c'
3537
- |
@@ -87,3 +89,8 @@ steps:
8789
export PYTHONPATH=./evalbench:./evalbench/evalproto
8890
8991
python3 evalbench/client/eval_client.py --experiment=/workspace/evals/run_config.yaml --endpoint=local || { echo "Client failed! Server logs:"; cat /evalbench/evalbench/server.log; exit 1; }
92+
93+
availableSecrets:
94+
secretManager:
95+
- versionName: projects/$PROJECT_ID/secrets/cloud-sql-postgres-password/versions/latest
96+
env: 'DB_PASSWORD'

0 commit comments

Comments
 (0)