#469 - quickfix existing deployments with default max_count

Author: justb4

GeoHealthCheck/plugins/probe/wfs.py

@@ -82,7 +82,7 @@ class WfsGetFeatureBbox(Probe):
             'type': 'string',
             'description': 'Maximum amount of features to select',
             'default': '5',
-            'required': True,
+            'required': False,
             'range': None
         },
         'bbox': {

GeoHealthCheck/probe.py

@@ -274,6 +274,14 @@ def perform_request(self):
                     if param_defs[param]['type'] == 'stringlist':
                         request_parms[param] = ','.join(request_parms[param])
 
+                # Some new params may have been defined,
+                # but not present in request params from DB.
+                for param_def in param_defs:
+                    if param_def not in request_parms \
+                            and 'default' in param_defs[param_def]:
+                        request_parms[param_def] = \
+                            param_defs[param_def]['default']
+
                 request_string = self.REQUEST_TEMPLATE.format(**request_parms)
 
         self.log('Requesting: %s url=%s' % (self.REQUEST_METHOD, url_base))

tests/data/fixtures.json

@@ -170,6 +170,17 @@
         "bbox": ["180635", "455870", "180961", "456050"]
       }
     },
+    "PDOK BAG WFS - GetFeature - default max_count": {
+      "resource": "PDOK BAG WFS",
+      "probe_class": "GeoHealthCheck.plugins.probe.wfs.WfsGetFeatureBbox",
+      "parameters": {
+        "type_name": "bag:verblijfsobject",
+        "type_ns_prefix": "bag",
+        "type_ns_uri": "http://bag.geonovum.nl",
+        "srs": "EPSG:28992",
+        "bbox": ["180635", "455870", "180961", "456050"]
+      }
+    },
     "PDOK BAG WFS - GetFeature All": {
       "resource": "PDOK BAG WFS",
       "probe_class": "GeoHealthCheck.plugins.probe.wfs.WfsGetFeatureBboxAll",
@@ -182,6 +193,17 @@
         "bbox": ["180635", "455870", "180961", "456050"]
       }
     },
+    "PDOK BAG WFS - GetFeature All - default max_count": {
+      "resource": "PDOK BAG WFS",
+      "probe_class": "GeoHealthCheck.plugins.probe.wfs.WfsGetFeatureBboxAll",
+      "parameters": {
+        "type_name": "all 5 featuretypes",
+        "type_ns_prefix": "bag",
+        "type_ns_uri": "http://bag.geonovum.nl",
+        "srs": "EPSG:28992",
+        "bbox": ["180635", "455870", "180961", "456050"]
+      }
+    },
     "PDOK CSW - GetCaps": {
       "resource": "PDOK CSW",
       "probe_class": "GeoHealthCheck.plugins.probe.owsgetcaps.CswGetCaps",