fix: address BugBot findings — ownership repair index alignment and dead code

1. cli/fix.ts: repairOwnership now returns RepairOutcome[] aligned by
   index with the input issues array, fixing the bug where mixed
   success/failure results were misaligned via separate fixed[]/failed[]
   arrays.

2. cli/upgrade.ts + human.ts: Remove unreachable 'channel-only' action
   variant from UpgradeResult.action union and formatter — no code path
   produces it. Can be re-added when the feature is implemented.

Author: BYK

src/commands/cli/fix.ts

@@ -269,33 +269,38 @@ function resolveUid(username: string): number | null {
  *
  * @returns Object with lists of human-readable success and failure messages
  */
+/** Per-issue repair outcome, aligned by index with the input issues array */
+type RepairOutcome = {
+  /** Whether the repair succeeded */
+  success: boolean;
+  /** Human-readable repair message */
+  message: string;
+};
+
 async function repairOwnership(
   issues: OwnershipIssue[],
   username: string,
   targetUid: number
-): Promise<{ fixed: string[]; failed: string[] }> {
-  const fixed: string[] = [];
-  const failed: string[] = [];
-
+): Promise<RepairOutcome[]> {
   const results = await Promise.allSettled(
     issues.map((issue) => chown(issue.path, targetUid, -1))
   );
 
-  for (let i = 0; i < results.length; i++) {
-    const result = results[i] as PromiseSettledResult<void>;
+  return results.map((result, i) => {
     const issue = issues[i] as OwnershipIssue;
     if (result.status === "fulfilled") {
-      fixed.push(`${issue.kind} ${issue.path}: transferred to ${username}`);
-    } else {
-      const reason =
-        result.reason instanceof Error
-          ? result.reason.message
-          : "unknown error";
-      failed.push(`${issue.kind} ${issue.path}: ${reason}`);
+      return {
+        success: true,
+        message: `${issue.kind} ${issue.path}: transferred to ${username}`,
+      };
     }
-  }
-
-  return { fixed, failed };
+    const reason =
+      result.reason instanceof Error ? result.reason.message : "unknown error";
+    return {
+      success: false,
+      message: `${issue.kind} ${issue.path}: ${reason}`,
+    };
+  });
 }
 
 /** Result of diagnosing a category of issues (used internally) */
@@ -413,34 +418,23 @@ async function handleOwnershipIssues(
   // Running as root — perform chown. resolvedTargetUid is guaranteed non-null
   // and non-zero here (we bailed out above if it couldn't be resolved).
   const resolvedUid = resolvedTargetUid as number;
-  const { fixed, failed } = await repairOwnership(
-    rawIssues,
-    username,
-    resolvedUid
-  );
+  const outcomes = await repairOwnership(rawIssues, username, resolvedUid);
 
-  // Mark each issue with its repair outcome
+  // Mark each issue with its repair outcome (aligned by index)
+  let anyFailed = false;
   for (let i = 0; i < fixIssues.length; i++) {
     const issue = fixIssues[i] as FixIssue;
-    if (i < fixed.length) {
-      issue.repaired = true;
-      issue.repairMessage = fixed[i];
+    const outcome = outcomes[i] as RepairOutcome;
+    issue.repaired = outcome.success;
+    issue.repairMessage = outcome.message;
+    if (!outcome.success) {
+      anyFailed = true;
     }
   }
 
-  // Append failed repairs as issues with repaired=false
-  for (const f of failed) {
-    fixIssues.push({
-      category: "ownership",
-      description: f,
-      repaired: false,
-      repairMessage: f,
-    });
-  }
-
   return {
     issues: fixIssues,
-    repairFailed: failed.length > 0,
+    repairFailed: anyFailed,
   };
 }
 

src/commands/cli/upgrade.ts

@@ -58,7 +58,7 @@ const CHANNEL_VERSIONS = new Set(["nightly", "stable"]);
  */
 export type UpgradeResult = {
   /** What action was taken */
-  action: "upgraded" | "downgraded" | "up-to-date" | "checked" | "channel-only";
+  action: "upgraded" | "downgraded" | "up-to-date" | "checked";
   /** Current CLI version before upgrade */
   currentVersion: string;
   /** Target version (the version we upgraded/downgraded to, or the latest available) */
@@ -120,7 +120,7 @@ type ResolveTargetOptions = {
  *
  * - `target`: the version string to upgrade/downgrade to (proceed with upgrade)
  * - `UpgradeResult`: structured result when no upgrade should proceed
- *   (check-only mode, already up to date, or channel-only switch)
+ *   (check-only mode, or already up to date)
  */
 type ResolveResult =
   | { kind: "target"; target: string }

src/lib/formatters/human.ts

@@ -2018,7 +2018,6 @@ const ACTION_DESCRIPTIONS: Record<UpgradeResult["action"], string> = {
   downgraded: "Downgraded",
   "up-to-date": "Already up to date",
   checked: "Update check complete",
-  "channel-only": "Channel updated",
 };
 
 /**
@@ -2066,11 +2065,6 @@ export function formatUpgradeResult(data: UpgradeResult): string {
       }
       break;
     }
-    case "channel-only":
-      lines.push(
-        `${colorTag("green", "✓")} Channel set to ${escapeMarkdownInline(data.channel)}`
-      );
-      break;
     default: {
       // Exhaustive check — all action types should be handled above
       const _: never = data.action;