Skip to content

Commit 43eb1cb

Browse files
committed
remove done todos
1 parent 684c10f commit 43eb1cb

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

sentry_sdk/scope.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,14 +1241,13 @@ def start_streamed_span(
12411241
if parent_span is None or isinstance(parent_span, NoOpStreamedSpan):
12421242
parent_span = self.span or self.get_current_scope().span # type: ignore
12431243

1244-
# If no specific parent_span was provided and there is no currently
1244+
# If no eligible parent_span was provided and there is no currently
12451245
# active span, this is a segment
12461246
if parent_span is None:
12471247
propagation_context = self.get_active_propagation_context()
12481248

12491249
if is_ignored_span(name, attributes):
12501250
return NoOpStreamedSpan(scope=self)
1251-
# TODO[span-first]: emit "ignored" client report
12521251

12531252
return StreamedSpan(
12541253
name=name,
@@ -1266,8 +1265,6 @@ def start_streamed_span(
12661265
if is_ignored_span(name, attributes) or isinstance(
12671266
parent_span, NoOpStreamedSpan
12681267
):
1269-
# TODO[span-first]: emit "ignored" client report
1270-
# also add tests for it
12711268
return NoOpStreamedSpan()
12721269

12731270
return StreamedSpan(

0 commit comments

Comments
 (0)