add span.end()

Author: sentrivana

sentry_sdk/traces.py

@@ -6,6 +6,7 @@
 """
 
 import uuid
+import warnings
 from datetime import datetime, timedelta, timezone
 from enum import Enum
 from typing import TYPE_CHECKING
@@ -361,7 +362,7 @@ def start(self) -> "StreamedSpan":
         """
         return self.__enter__()
 
-    def finish(self, end_timestamp: "Optional[Union[float, datetime]]" = None) -> None:
+    def end(self, end_timestamp: "Optional[Union[float, datetime]]" = None) -> None:
         """
         Finish this span and queue it for sending.
 
@@ -378,6 +379,15 @@ def finish(self, end_timestamp: "Optional[Union[float, datetime]]" = None) -> No
 
         self.__exit__(None, None, None)
 
+    def finish(self, end_timestamp: "Optional[Union[float, datetime]]" = None) -> None:
+        warnings.warn(
+            "span.finish() is deprecated. Use span.end() instead."
+            stacklevel=2,
+            category=DeprecationWarning,
+        )
+
+        self.end(end_timestamp)
+
     def _end(
         self,
         scope: "Optional[sentry_sdk.Scope]" = None,