git: add 'GetRemoteUrl()'

Add a 'GetRemoteUrl()' function to 'git.GitHelper', which calls 'git remote
get-url origin' on a given repository path and returns the whitespace-
trimmed remote URL. Neither stdout nor stderr are printed to the console,
but the stderr text is included in the error message if Git exits with an
error status.

Although it is not used in this patch, 'GetRemoteUrl()' will be used in
later commits to display information about the configuration of the bundle
server.

Signed-off-by: Victoria Dye <vdye@github.com>

Author: vdye

internal/git/git.go

@@ -17,6 +17,7 @@ type GitHelper interface {
 	CreateIncrementalBundle(ctx context.Context, repoDir string, filename string, prereqs []string) (bool, error)
 	CloneBareRepo(ctx context.Context, url string, destination string) error
 	UpdateBareRepo(ctx context.Context, repoDir string) error
+	GetRemoteUrl(ctx context.Context, repoDir string) (string, error)
 }
 
 type gitHelper struct {
@@ -47,6 +48,25 @@ func (g *gitHelper) gitCommand(ctx context.Context, args ...string) error {
 	return nil
 }
 
+func (g *gitHelper) gitCommandQuiet(ctx context.Context, args ...string) (*bytes.Buffer, *bytes.Buffer, error) {
+	stdout := &bytes.Buffer{}
+	stderr := &bytes.Buffer{}
+
+	exitCode, err := g.cmdExec.Run(ctx, "git", args,
+		cmd.Stdout(stdout),
+		cmd.Stderr(stderr),
+		cmd.Env([]string{"LC_CTYPE=C"}),
+	)
+
+	if err != nil {
+		return nil, nil, g.logger.Error(ctx, err)
+	} else if exitCode != 0 {
+		return stdout, stderr, g.logger.Errorf(ctx, "'git' exited with status %d\n%s", exitCode, stderr.String())
+	}
+
+	return stdout, stderr, nil
+}
+
 func (g *gitHelper) gitCommandWithStdin(ctx context.Context, stdinLines []string, args ...string) error {
 	buffer := bytes.Buffer{}
 	for line := range stdinLines {
@@ -149,3 +169,11 @@ func (g *gitHelper) UpdateBareRepo(ctx context.Context, repoDir string) error {
 
 	return nil
 }
+
+func (g *gitHelper) GetRemoteUrl(ctx context.Context, repoDir string) (string, error) {
+	stdout, _, gitErr := g.gitCommandQuiet(ctx, "-C", repoDir, "remote", "get-url", "origin")
+	if gitErr != nil {
+		return "", g.logger.Errorf(ctx, "failed to get remote URL: %w", gitErr)
+	}
+	return strings.TrimSpace(stdout.String()), nil
+}

internal/testhelpers/mocks.go

@@ -229,3 +229,8 @@ func (m *MockGitHelper) UpdateBareRepo(ctx context.Context, repoDir string) erro
 	fnArgs := m.Called(ctx, repoDir)
 	return fnArgs.Error(0)
 }
+
+func (m *MockGitHelper) GetRemoteUrl(ctx context.Context, repoDir string) (string, error) {
+	fnArgs := m.Called(ctx, repoDir)
+	return fnArgs.String(0), fnArgs.Error(1)
+}