Added test for not allowed files

Author: carlosb1

app/mod_photos/controllers.py

@@ -7,25 +7,43 @@
 import uuid
 import os
 
+ALLOWED_EXTENSIONS=set(['jpg','jpeg','bmp','png'])
+
 mod_photos = Blueprint('photos',__name__,url_prefix='/photos/v1.0')
 
+def allowed_file(filename):
+	return '.' in filename and filename.rsplit('.',1)[1] in ALLOWED_EXTENSIONS
+
+
 @mod_photos.route('/photos',methods=['POST'])
 def photos():
 	app.logger.debug("Applying post photo...")
 
         data = None
         if request.method == 'POST':
 		file = request.files['file']
+		if file and not allowed_file(file.filename):
+            	    resp = jsonify()
+        	    resp.content_type='application/json'
+    		    resp.status_code = 202
+		    return resp
+
 		extension = os.path.splitext(file.filename)[1]
 		f_name=str(uuid.uuid4()) + extension
-		file.save(os.path.join(app.config['UPLOAD_FOLDER'], f_name))
+		filepath=os.path.join(app.config['UPLOAD_FOLDER'], f_name)
+		photo = Photo(f_name,filepath)
+		data ={'uuid':f_name, 'filepath': filepath}
+		Photo.create(**data)
+		file.save(filepath)
                 data = {'filename':f_name}
         #TODO refactor to set up necessary methods to create responses
         if data == None:
             resp = jsonify()
+            resp.status_code = 200
         else:
             resp = jsonify(data)
+	    resp.status_code = 201
+	#TODO add diferent type of constructors
         resp.content_type='application/json'
-        resp.status_code == 200
         return resp
 

app/mod_photos/models.py

@@ -8,15 +8,17 @@ class Base(db.Model):
 
 class Photo(Base,CRUDMixin):
     __tablename__='photo'
-    name = db.Column(db.String(128), nullable=False)
+    uuid = db.Column(db.String(128), nullable=False)
+    filepath = db.Column(db.String(500), nullable=False)
 
-    def __init__(self,name):
-	self.name = name
+    def __init__(self,uuid,filepath):
+	self.uuid = uuid
+	self.filepath = filepath
 
     def get_id(self):
 	return self.id
 
     def __repr__(self):
-        return '<photo %r>' % (self.name)
+	return '<photo uuid=%r filepath=%r>' % (self.name,self.uuid,self.filepath)
 
 

app/mod_photos/tests.py

@@ -9,8 +9,9 @@
 
 class TestModelPhoto(BaseTestCase):
     def test_new_photo(self):
-        photo = Photo('carlos')
-        self.assertTrue(photo.name,'carlos')
+        photo = Photo('1','/test/photo.png')
+        self.assertTrue(photo.uuid,'1')
+        self.assertTrue(photo.filepath,'/test/photo.png')
 
 class TestPhotosViews(BaseTestCase):
     def test_post_photo_correct(self):
@@ -22,6 +23,13 @@ def test_post_photo_correct(self):
 		print dir(response)
 		self.app.logger.debug(response.json)
 		#TODO add assert for correct response
-		self.assert_200(response)
+		self.assertTrue(response.status_code == 201)
     def post_photo_not_allowed_file(self):
-	    pass
+        with self.app.open_resource("test_resources/photo.txt") as fp:
+             with self.client:
+                response = self.client.post("/photos/v1.0/photos",data={'file':fp});
+		app.logger.debug(response)
+		#self.app.logger.debug(response.json)
+		#TODO add assert for correct response
+		self.assertTrue(response.status_code == 202)
+