Merge pull request #17991 from igfoo/igfoo/redundant

igfoo · web-flow · commit b1ac02795b0e · 2024-11-15T10:55:56.000Z
Go: Remove a redundant override
diff --git a/go/ql/src/RedundantCode/RedundantExpr.ql b/go/ql/src/RedundantCode/RedundantExpr.ql
@@ -71,10 +71,6 @@ class AverageExpr extends PotentiallyRedundantExpr, AddExpr {
       this.getLeftOperand().getKind() = this.getRightOperand().getKind()
     )
   }
-
-  override predicate operands(Expr left, Expr right) {
-    left = this.getLeftOperand() and right = this.getRightOperand()
-  }
 }
 
 /** Gets the hash of `nd`, which is the `i`th operand of `red`. */

Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,6 @@ class AverageExpr extends PotentiallyRedundantExpr, AddExpr {`
`71`	`71`	`this.getLeftOperand().getKind() = this.getRightOperand().getKind()`
`72`	`72`	`)`
`73`	`73`	`}`
`74`		`-`
`75`		`- override predicate operands(Expr left, Expr right) {`
`76`		`- left = this.getLeftOperand() and right = this.getRightOperand()`
`77`		`- }`
`78`	`74`	`}`
`79`	`75`
`80`	`76`	/** Gets the hash of `nd`, which is the `i`th operand of `red`. */