From 638dc9380c596ed0bdbd66b78495678b68d2c40a Mon Sep 17 00:00:00 2001 From: Asger F Date: Thu, 7 May 2026 23:40:18 +0200 Subject: [PATCH 1/2] Shared: Nicer panic message if node kind is missing Still panics, just with a better message --- shared/tree-sitter-extractor/src/extractor/mod.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/shared/tree-sitter-extractor/src/extractor/mod.rs b/shared/tree-sitter-extractor/src/extractor/mod.rs index 0c3e13660817..4ec16269c1f6 100644 --- a/shared/tree-sitter-extractor/src/extractor/mod.rs +++ b/shared/tree-sitter-extractor/src/extractor/mod.rs @@ -479,13 +479,14 @@ impl<'a> Visitor<'a> { let (id, _, child_nodes) = self.stack.pop().expect("Vistor: empty stack"); let loc = location_for(self, self.file_label, node); let loc_label = location_label(self.trap_writer, loc); + let type_name = TypeName { + kind: node.kind().to_owned(), + named: node.is_named(), + }; let table = self .schema - .get(&TypeName { - kind: node.kind().to_owned(), - named: node.is_named(), - }) - .unwrap(); + .get(&type_name) + .unwrap_or_else(|| panic!("missing extractor schema entry for {:?}", type_name)); let mut valid = true; let parent_info = match self.stack.last_mut() { Some(p) if !node.is_extra() => { From 9a1c2da5d9e1b5ca7fb8f8c246827351ca89d5c8 Mon Sep 17 00:00:00 2001 From: Asger F Date: Fri, 8 May 2026 14:22:01 +0200 Subject: [PATCH 2/2] Fix clippy: inline variable in format string Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- shared/tree-sitter-extractor/src/extractor/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shared/tree-sitter-extractor/src/extractor/mod.rs b/shared/tree-sitter-extractor/src/extractor/mod.rs index 4ec16269c1f6..00816a00fd04 100644 --- a/shared/tree-sitter-extractor/src/extractor/mod.rs +++ b/shared/tree-sitter-extractor/src/extractor/mod.rs @@ -486,7 +486,7 @@ impl<'a> Visitor<'a> { let table = self .schema .get(&type_name) - .unwrap_or_else(|| panic!("missing extractor schema entry for {:?}", type_name)); + .unwrap_or_else(|| panic!("missing extractor schema entry for {type_name:?}")); let mut valid = true; let parent_info = match self.stack.last_mut() { Some(p) if !node.is_extra() => {