rm update pr base logic, should all happen on server

Author: skarim

cmd/push.go

@@ -152,16 +152,7 @@ func runPush(cfg *config.Config, opts *pushOptions) error {
 				URL:    newPR.URL,
 			}
 		} else {
-			// Update base if needed
-			if pr.BaseRefName != baseBranch {
-				if err := client.UpdatePRBase(pr.ID, baseBranch); err != nil {
-					cfg.Warningf("failed to update PR %s base: %v", cfg.PRLink(pr.Number, pr.URL), err)
-				} else {
-					cfg.Successf("Updated PR %s base to %s", cfg.PRLink(pr.Number, pr.URL), baseBranch)
-				}
-			} else {
-				cfg.Printf("PR %s for %s is up to date", cfg.PRLink(pr.Number, pr.URL), b.Branch)
-			}
+			cfg.Printf("PR %s for %s is up to date", cfg.PRLink(pr.Number, pr.URL), b.Branch)
 			if s.Branches[i].PullRequest == nil {
 				s.Branches[i].PullRequest = &stack.PullRequestRef{
 					Number: pr.Number,

internal/github/client_interface.go

@@ -8,7 +8,6 @@ type ClientOps interface {
 	FindAnyPRForBranch(branch string) (*PullRequest, error)
 	FindPRDetailsForBranch(branch string) (*PRDetails, error)
 	CreatePR(base, head, title, body string, draft bool) (*PullRequest, error)
-	UpdatePRBase(prID, newBase string) error
 	DeleteStack() error
 }
 

internal/github/github.go

@@ -185,31 +185,6 @@ func (c *Client) CreatePR(base, head, title, body string, draft bool) (*PullRequ
 	}, nil
 }
 
-// UpdatePRBase updates the base branch of a pull request.
-func (c *Client) UpdatePRBase(prID, newBase string) error {
-	var mutation struct {
-		UpdatePullRequest struct {
-			PullRequest struct {
-				ID string
-			}
-		} `graphql:"updatePullRequest(input: $input)"`
-	}
-
-	type UpdatePullRequestInput struct {
-		PullRequestID string `json:"pullRequestId"`
-		BaseRefName   string `json:"baseRefName"`
-	}
-
-	variables := map[string]interface{}{
-		"input": UpdatePullRequestInput{
-			PullRequestID: prID,
-			BaseRefName:   newBase,
-		},
-	}
-
-	return c.gql.Mutate("UpdatePullRequest", &mutation, variables)
-}
-
 // PRDetails holds enriched pull request data for display in the TUI.
 type PRDetails struct {
 	Number        int

internal/github/mock_client.go

@@ -9,9 +9,8 @@ type MockClient struct {
 	FindPRForBranchFn        func(string) (*PullRequest, error)
 	FindAnyPRForBranchFn     func(string) (*PullRequest, error)
 	FindPRDetailsForBranchFn func(string) (*PRDetails, error)
-	CreatePRFn               func(string, string, string, string, bool) (*PullRequest, error)
-	UpdatePRBaseFn           func(string, string) error
-	DeleteStackFn            func() error
+	CreatePRFn    func(string, string, string, string, bool) (*PullRequest, error)
+	DeleteStackFn func() error
 }
 
 // Compile-time check that MockClient satisfies ClientOps.
@@ -45,13 +44,6 @@ func (m *MockClient) CreatePR(base, head, title, body string, draft bool) (*Pull
 	return nil, nil
 }
 
-func (m *MockClient) UpdatePRBase(prID, newBase string) error {
-	if m.UpdatePRBaseFn != nil {
-		return m.UpdatePRBaseFn(prID, newBase)
-	}
-	return nil
-}
-
 func (m *MockClient) DeleteStack() error {
 	if m.DeleteStackFn != nil {
 		return m.DeleteStackFn()