output msgs nits

Author: skarim

cmd/add.go

@@ -106,6 +106,6 @@ func runAdd(cfg *config.Config, args []string) error {
 		return nil
 	}
 
-	cfg.Successf("Created and checked out branch %q\n", branchName)
+	cfg.Successf("Created and checked out branch %q", branchName)
 	return nil
 }

cmd/checkout.go

@@ -38,6 +38,6 @@ func CheckoutCmd(cfg *config.Config) *cobra.Command {
 //  4. Save the stack to local tracking (.git/gh-stack, similar to gh stack init --adopt)
 //  5. Switch to the target branch (unless --no-switch is set)
 func runCheckout(cfg *config.Config, opts *checkoutOptions) error {
-	cfg.Warningf("gh stack checkout is not yet implemented\n")
+	cfg.Warningf("gh stack checkout is not yet implemented")
 	return nil
 }

cmd/feedback.go

@@ -37,6 +37,6 @@ func runFeedback(cfg *config.Config, args []string) error {
 		return err
 	}
 
-	cfg.Successf("Opening feedback form in your browser...\n")
+	cfg.Successf("Opening feedback form in your browser...")
 	return nil
 }

cmd/merge.go

@@ -26,6 +26,6 @@ func MergeCmd(cfg *config.Config) *cobra.Command {
 // We need a mergeability check for the entire stack
 // and an endpoint for merging an entire stack
 func runMerge(cfg *config.Config, opts struct{}) error {
-	cfg.Warningf("gh stack merge is not yet implemented\n")
+	cfg.Warningf("gh stack merge is not yet implemented")
 	return nil
 }

cmd/rebase.go

@@ -118,7 +118,7 @@ func runRebase(cfg *config.Config, opts *rebaseOptions) error {
 	if err := git.Fetch("origin"); err != nil {
 		cfg.Warningf("Failed to fetch origin: %v", err)
 	} else {
-		cfg.Successf("Fetching origin")
+		cfg.Successf("Fetched origin")
 	}
 
 	chainParts := []string{s.Trunk.Branch}

cmd/root.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"fmt"
 	"os"
 
 	"github.com/github/gh-stack/internal/config"
@@ -56,6 +57,7 @@ func RootCmd() *cobra.Command {
 func Execute() {
 	cmd := RootCmd()
 	if err := cmd.Execute(); err != nil {
+		fmt.Fprintln(cmd.ErrOrStderr(), err)
 		os.Exit(1)
 	}
 }

cmd/utils.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"fmt"
-	"os"
 
 	"github.com/cli/go-gh/v2/pkg/prompter"
 	"github.com/github/gh-stack/internal/config"
@@ -30,14 +29,14 @@ func resolveStack(sf *stack.StackFile, branch string, cfg *config.Config) (*stac
 		return nil, fmt.Errorf("branch %q belongs to multiple stacks; use an interactive terminal to select one", branch)
 	}
 
-	cfg.Warningf("Branch %q is the trunk of multiple stacks\n", branch)
+	cfg.Warningf("Branch %q is the trunk of multiple stacks", branch)
 
 	options := make([]string, len(stacks))
 	for i, s := range stacks {
 		options[i] = s.DisplayName()
 	}
 
-	p := prompter.New(os.Stdin, os.Stdout, os.Stderr)
+	p := prompter.New(cfg.In, cfg.Out, cfg.Err)
 	selected, err := p.Select("Which stack would you like to use?", "", options)
 	if err != nil {
 		return nil, fmt.Errorf("stack selection: %w", err)
@@ -52,7 +51,7 @@ func resolveStack(sf *stack.StackFile, branch string, cfg *config.Config) (*stac
 		if err := git.CheckoutBranch(topBranch); err != nil {
 			return nil, fmt.Errorf("failed to checkout branch %s: %w", topBranch, err)
 		}
-		cfg.Successf("Switched to %s\n", topBranch)
+		cfg.Successf("Switched to %s", topBranch)
 	}
 
 	return s, nil