adressing review comments

Author: skarim

cmd/checkout.go

@@ -211,10 +211,13 @@ func checkoutRemoteStack(cfg *config.Config, sf *stack.StackFile, gitDir string,
 	localStack := findLocalStackForRemotePRs(sf, prs)
 
 	if localStack != nil {
+		// Sync remote PR metadata before comparing composition so locally
+		// tracked stacks with incomplete PR refs don't appear to conflict.
+		syncRemotePRState(localStack, prs)
+
 		// Case A: branch is in a local stack — check composition
 		if stackCompositionMatches(localStack, remoteStack.PullRequests) {
-			// Composition matches — sync PR state and checkout
-			syncRemotePRState(localStack, prs)
+			// Composition matches — checkout
 			if localStack.ID == "" {
 				localStack.ID = remoteStackID
 			}
@@ -280,6 +283,9 @@ func fetchStackPRDetails(client github.ClientOps, prNumbers []int) ([]*github.Pu
 		if err != nil {
 			return nil, fmt.Errorf("fetching PR #%d: %w", n, err)
 		}
+		if pr == nil {
+			return nil, fmt.Errorf("PR #%d not found", n)
+		}
 		prs = append(prs, pr)
 	}
 	return prs, nil
@@ -450,7 +456,8 @@ func importRemoteStack(
 	if !git.BranchExists(trunk) {
 		remoteTrunk := remote + "/" + trunk
 		if err := git.CreateBranch(trunk, remoteTrunk); err != nil {
-			cfg.Warningf("could not pull trunk branch %s: %v", trunk, err)
+			cfg.Errorf("could not create trunk branch %s from %s: %v", trunk, remoteTrunk, err)
+			return nil, ErrSilent
 		}
 	}
 

cmd/utils.go

@@ -79,7 +79,7 @@ func clearSelectPrompt(cfg *config.Config, numOptions int) {
 	}
 	// 1 line for the question/filter + visible option lines
 	lines := 1 + visible
-	fmt.Fprintf(cfg.Err, "\033[%dA\033[J", lines)
+	fmt.Fprintf(cfg.Out, "\033[%dA\033[J", lines)
 }
 
 // loadStackResult holds everything returned by loadStack.