chores: fix branches tests

Author: madkoo

docs/sample-settings/sample-deployment-settings.yml

@@ -27,10 +27,10 @@ overridevalidators:
     error: |
       `Branch protection required_approving_review_count cannot be overidden to a lower value`
     script: |
-      console.log(`baseConfig ${JSON.stringify(baseconfig)}`)
-      console.log(`overrideConfig ${JSON.stringify(overrideconfig)}`)
-      if (baseconfig.protection.required_pull_request_reviews.required_approving_review_count && overrideconfig.protection.required_pull_request_reviews.required_approving_review_count ) {
-        return overrideconfig.protection.required_pull_request_reviews.required_approving_review_count >= baseconfig.protection.required_pull_request_reviews.required_approving_review_count
+      const baseCount = baseconfig?.protection?.required_pull_request_reviews?.required_approving_review_count
+      const overrideCount = overrideconfig?.protection?.required_pull_request_reviews?.required_approving_review_count
+      if (baseCount && overrideCount) {
+        return overrideCount >= baseCount
       }
       return true
   - plugin: labels

test/unit/lib/plugins/branches.test.js

@@ -67,6 +67,7 @@ describe('Branches', () => {
           required_pull_request_reviews: {
             require_code_owner_reviews: true
           },
+          restrictions: null,
           headers: { accept: 'application/vnd.github.hellcat-preview+json,application/vnd.github.luke-cage-preview+json,application/vnd.github.zzzax-preview+json' }
         })
       })
@@ -190,6 +191,8 @@ describe('Branches', () => {
               strict: true,
               contexts: []
             },
+            enforce_admins: null,
+            restrictions: null,
             headers: { accept: 'application/vnd.github.hellcat-preview+json,application/vnd.github.luke-cage-preview+json,application/vnd.github.zzzax-preview+json' }
           })
         })
@@ -229,6 +232,8 @@ describe('Branches', () => {
               strict: true,
               contexts: ['check-1', 'check-2']
             },
+            enforce_admins: null,
+            restrictions: null,
             headers: { accept: 'application/vnd.github.hellcat-preview+json,application/vnd.github.luke-cage-preview+json,application/vnd.github.zzzax-preview+json' }
           })
         })
@@ -267,6 +272,8 @@ describe('Branches', () => {
             repo: 'test',
             branch: 'other',
             enforce_admins: false,
+            required_status_checks: null,
+            restrictions: null,
             headers: { accept: 'application/vnd.github.hellcat-preview+json,application/vnd.github.luke-cage-preview+json,application/vnd.github.zzzax-preview+json' }
           })
         })