Merge branch 'ef-migrating-more-ruby-tests-to-go' into 'main'

Removes more Ruby Spec tests in favour of Go tests

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/1367

Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: e_forbes <eforbes@gitlab.com>

Author: 2 people

cmd/gitlab-shell-authorized-keys-check/command/command_test.go

@@ -60,6 +60,15 @@ func TestParseSuccess(t *testing.T) {
 			arguments:    []string{"git", "git", "key"},
 			expectedArgs: &commandargs.AuthorizedKeys{Arguments: []string{"git", "git", "key"}, ExpectedUser: "git", ActualUser: "git", Key: "key"},
 		},
+		{
+			// this seems counter-intuitive, but this ensures we're preserving the
+			// current logic when handling this situation/
+			desc:         "No error when expected user does not match actual user",
+			executable:   &executable.Executable{Name: executable.AuthorizedKeysCheck},
+			arguments:    []string{"expected", "actual", "key"},
+			expectedArgs: &commandargs.AuthorizedKeys{Arguments: []string{"expected", "actual", "key"}, ExpectedUser: "expected", ActualUser: "actual", Key: "key"},
+			expectError:  false,
+		},
 	}
 
 	for _, tc := range testCases {
@@ -109,11 +118,9 @@ func TestParseFailure(t *testing.T) {
 			expectedError: "# No key provided",
 		},
 	}
-
 	for _, tc := range testCases {
 		t.Run(tc.desc, func(t *testing.T) {
 			_, err := command.Parse(tc.arguments)
-
 			require.EqualError(t, err, tc.expectedError)
 		})
 	}