linting and benchmark

Author: gms1

.editorconfig

@@ -0,0 +1,53 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# Top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+# Matches multiple files with the same settings
+[*.js]
+indent_size = 2
+
+[*.json]
+indent_size = 2
+
+[*.yml]
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false
+indent_size = 2
+
+[*.sql]
+indent_size = 2
+
+# C/C++ files
+[*.cc]
+indent_size = 2
+indent_style = tab
+max_line_length = 100
+
+[*.h]
+indent_size = 2
+indent_style = tab
+max_line_length = 100
+
+# Makefile and GYP files use tabs
+[{Makefile,*.gyp}]
+indent_style = tab
+
+# Dockerfiles
+[Dockerfile]
+indent_size = 2
+
+# YAML files
+[*.yaml]
+indent_size = 2

.eslintrc.js

@@ -8,6 +8,7 @@ module.exports = {
         "indent": ["error", 4],
         "linebreak-style": ["error", "unix"],
         "semi": ["error", "always"],
-        "no-cond-assign": ["error", "always"]
+      "no-cond-assign": ["error", "always"],
+      "no-inner-declarations": "off"
     }
 };

.gitattributes

@@ -0,0 +1,4 @@
+# Mark SQLite database files as binary to prevent line ending conversions
+*.db binary
+*.sqlite binary
+*.sqlite3 binary

package.json

@@ -50,6 +50,7 @@
     "tar": "^7.5.10"
   },
   "devDependencies": {
+    "benchmark": "^2.1.4",
     "eslint": "8.56.0",
     "mocha": "10.2.0",
     "prebuild": "13.0.1"
@@ -73,6 +74,7 @@
     "prebuild": "prebuild --runtime napi --all --verbose",
     "rebuild": "node-gyp rebuild",
     "upload": "prebuild --verbose --prerelease",
+    "lint": "eslint lib/ test/ tools/",
     "test": "node test/support/createdb.js && mocha -R spec --timeout 480000"
   },
   "license": "BSD-3-Clause",

test/.eslintrc.js

@@ -2,4 +2,8 @@ module.exports = {
     env: {
         mocha: true,
     },
+    extends: '../.eslintrc.js',
+    rules: {
+        'no-unused-vars': 'off'
+    }
 };

test/async_calls.test.js

@@ -1,4 +1,4 @@
-"use strict"
+"use strict";
 
 var sqlite3 = require('..');
 const assert = require("assert");

test/patching.test.js

@@ -1,5 +1,6 @@
 var sqlite3 = require('..');
 var assert = require('assert');
+var helper = require('./support/helper');
 
 describe('patching', function() {
     describe("Database", function() {
@@ -20,8 +21,8 @@ describe('patching', function() {
         it('allow patching native functions', function() {
             var myFun = function myFunction() {
                 return "Success";
-            }
-            
+            };
+
             assert.doesNotThrow(() => {
                 sqlite3.Database.prototype.close = myFun;
             });
@@ -91,8 +92,8 @@ describe('patching', function() {
         it('allow patching native functions', function() {
             var myFun = function myFunction() {
                 return "Success";
-            }
-            
+            };
+
             assert.doesNotThrow(() => {
                 sqlite3.Statement.prototype.bind = myFun;
             });
@@ -147,6 +148,10 @@ describe('patching', function() {
         var backup;
         var originalFunctions = {};
 
+        before(function () {
+            helper.ensureExists('test/tmp');
+        });
+
         before(function() {
             originalFunctions.step = sqlite3.Backup.prototype.step;
             originalFunctions.finish = sqlite3.Backup.prototype.finish;
@@ -155,8 +160,8 @@ describe('patching', function() {
         it('allow patching native functions', function() {
             var myFun = function myFunction() {
                 return "Success";
-            }
-            
+            };
+
             assert.doesNotThrow(() => {
                 sqlite3.Backup.prototype.step = myFun;
             });
@@ -165,7 +170,7 @@ describe('patching', function() {
             });
 
             db = new sqlite3.Database(':memory:');
-            backup = db.backup("somefile", myFun);
+            backup = db.backup("test/tmp/patching_backup.db", myFun);
             assert.strictEqual(backup.step(), "Success");
             assert.strictEqual(backup.finish(), "Success");
         });
@@ -176,6 +181,7 @@ describe('patching', function() {
                 sqlite3.Backup.prototype.finish = originalFunctions.finish;
                 backup.finish();
             }
+            helper.deleteFile('test/tmp/patching_backup.db');
             if(db != null) {
                 db.close();
             }

test/support/createdb.js

@@ -19,7 +19,7 @@ function createdb(callback) {
         return str;
     }
 
-// Make sure the file exists and is also valid.
+    // Make sure the file exists and is also valid.
     if (existsSync(db_path) && statSync(db_path).size !== 0) {
         console.log('okay: database already created (' + db_path + ')');
         if (callback) callback();

test/unicode.test.js

@@ -71,7 +71,7 @@ describe('unicode', function() {
     // Generate random data.
     var data = [];
     var length = Math.floor(Math.random() * 1000) + 200;
-    for (var i = 0; i < length; i++) {
+    for (i = 0; i < length; i++) {
         data.push(randomString());
     }
 

tools/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+    extends: '../.eslintrc.js',
+    rules: {
+        'no-unused-vars': 'off'
+    }
+};