Fix tests

Author: ScottMansfield

tests/unittests/sessions/test_firestore_session_service.py

@@ -164,3 +164,50 @@ async def test_append_event(mock_firestore_client):
   batch.set.assert_called_once()  # For event
   batch.update.assert_called_once()  # For session updateTime
   batch.commit.assert_called_once()
+
+
+@pytest.mark.asyncio
+async def test_append_event_with_state_delta(mock_firestore_client):
+  service = FirestoreSessionService(client=mock_firestore_client)
+  app_name = "test_app"
+  user_id = "test_user"
+  from google.adk.sessions.session import Session
+
+  session = Session(id="test_session", app_name=app_name, user_id=user_id)
+
+  # Using MagicMock for Event to bypass complex pydantic validation for test
+  event = mock.MagicMock()
+  event.partial = False
+  event.id = "test_event_id"
+  # Mock actions.state_delta
+  event.actions.state_delta = {
+      "_app_my_key": "app_val",
+      "_user_my_key": "user_val",
+      "session_key": "session_val",
+  }
+  # Mock model_dump to return valid event data
+  event.model_dump.return_value = {"id": "test_event_id", "author": "user"}
+
+  await service.append_event(session, event)
+
+  mock_firestore_client.batch.assert_called_once()
+  batch = mock_firestore_client.batch.return_value
+
+  # Verify app state set
+  # In code: batch.set(app_ref, app_updates, merge=True)
+  # But app_ref is a mock! Which mock?
+  # It's mock_firestore_client.collection().document()
+  # In fixture: collection_ref = mock.AsyncMock()
+  # doc_ref = mock.AsyncMock()
+  # client.collection.return_value = collection_ref
+  # collection_ref.document.return_value = doc_ref
+  # So batch.set is called with app_ref (which is doc_ref)
+  batch.set.assert_called()
+
+  # Verify session state updated in memory
+  assert session.state["session_key"] == "session_val"
+
+  # Verify batch update was called for session
+  batch.update.assert_called_once()
+
+  batch.commit.assert_called_once()

tests/unittests/test_firestore_database_runner.py

@@ -0,0 +1,62 @@
+# Copyright 2026 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from __future__ import annotations
+
+from unittest import mock
+
+import pytest
+from google.adk.agents.base_agent import BaseAgent
+from google.adk.firestore_database_runner import create_firestore_runner
+
+
+@pytest.fixture
+def mock_agent():
+  agent = mock.MagicMock(spec=BaseAgent)
+  agent.name = "test_agent"
+  return agent
+
+
+def test_create_firestore_runner_with_arg(mock_agent, monkeypatch):
+  monkeypatch.delenv("ADK_GCS_BUCKET_NAME", raising=False)
+
+  # Mock GcsArtifactService to avoid real client init
+  with mock.patch(
+      "google.adk.firestore_database_runner.GcsArtifactService"
+  ) as mock_gcs:
+    runner = create_firestore_runner(mock_agent, gcs_bucket_name="test_bucket")
+
+    assert runner is not None
+    mock_gcs.assert_called_once_with(bucket_name="test_bucket")
+
+
+def test_create_firestore_runner_with_env(mock_agent, monkeypatch):
+  monkeypatch.setenv("ADK_GCS_BUCKET_NAME", "env_bucket")
+
+  with mock.patch(
+      "google.adk.firestore_database_runner.GcsArtifactService"
+  ) as mock_gcs:
+    runner = create_firestore_runner(mock_agent)
+
+    assert runner is not None
+    mock_gcs.assert_called_once_with(bucket_name="env_bucket")
+
+
+def test_create_firestore_runner_missing_bucket(mock_agent, monkeypatch):
+  monkeypatch.delenv("ADK_GCS_BUCKET_NAME", raising=False)
+
+  with pytest.raises(
+      ValueError, match="Required property 'ADK_GCS_BUCKET_NAME' is not set"
+  ):
+    create_firestore_runner(mock_agent)