Remove dead code

Author: ScottMansfield

src/google/adk/integrations/firestore/firestore_session_service.py

@@ -152,6 +152,7 @@ async def _create_txn(transaction: firestore.AsyncTransaction) -> None:
       snap = await session_ref.get(transaction=transaction)
       if snap.exists:
         from ...errors.already_exists_error import AlreadyExistsError
+
         raise AlreadyExistsError(f"Session {session_id} already exists.")
       transaction.set(session_ref, session_data)
 
@@ -240,7 +241,9 @@ async def list_sessions(
   ) -> ListSessionsResponse:
     """Lists sessions from Firestore."""
     if user_id:
-      query = self._get_sessions_ref(app_name, user_id).where("appName", "==", app_name)
+      query = self._get_sessions_ref(app_name, user_id).where(
+          "appName", "==", app_name
+      )
       docs = await query.get()
     else:
       query = self.client.collection_group(self.sessions_collection).where(
@@ -320,52 +323,6 @@ async def delete_session(
 
     await session_ref.delete()
 
-
-  async def _update_app_state_transactional(
-      self, app_name: str, delta: dict[str, Any]
-  ) -> dict[str, Any]:
-    """Atomically applies delta to app state inside a transaction."""
-    from google.cloud import firestore
-
-    doc_ref = self.client.collection(self.app_state_collection).document(
-        app_name
-    )
-
-    @firestore.async_transactional  # type: ignore[untyped-decorator]
-    async def _txn(transaction: firestore.AsyncTransaction) -> dict[str, Any]:
-      snap = await doc_ref.get(transaction=transaction)
-      current = snap.to_dict() if snap.exists else {}
-      current.update(delta)
-      transaction.set(doc_ref, current, merge=True)
-      return current
-
-    transaction = self.client.transaction()
-    return cast(dict[str, Any], await _txn(transaction))
-
-  async def _update_user_state_transactional(
-      self, app_name: str, user_id: str, delta: dict[str, Any]
-  ) -> dict[str, Any]:
-    """Atomically applies delta to user state inside a transaction."""
-    from google.cloud import firestore
-
-    doc_ref = (
-        self.client.collection(self.user_state_collection)
-        .document(app_name)
-        .collection("users")
-        .document(user_id)
-    )
-
-    @firestore.async_transactional  # type: ignore[untyped-decorator]
-    async def _txn(transaction: firestore.AsyncTransaction) -> dict[str, Any]:
-      snap = await doc_ref.get(transaction=transaction)
-      current = snap.to_dict() if snap.exists else {}
-      current.update(delta)
-      transaction.set(doc_ref, current, merge=True)
-      return current
-
-    transaction = self.client.transaction()
-    return cast(dict[str, Any], await _txn(transaction))
-
   async def append_event(self, session: Session, event: Event) -> Event:
     """Appends an event to a session in Firestore."""
     from google.cloud import firestore
@@ -376,7 +333,9 @@ async def append_event(self, session: Session, event: Event) -> Event:
     self._apply_temp_state(session, event)
     event = self._trim_temp_delta_state(event)
 
-    session_ref = self._get_sessions_ref(session.app_name, session.user_id).document(session.id)
+    session_ref = self._get_sessions_ref(
+        session.app_name, session.user_id
+    ).document(session.id)
 
     if event.actions and event.actions.state_delta:
       state_delta = event.actions.state_delta
@@ -392,7 +351,9 @@ async def append_event(self, session: Session, event: Event) -> Event:
         else:
           session_updates[key] = value
 
-      app_ref = self.client.collection(self.app_state_collection).document(session.app_name)
+      app_ref = self.client.collection(self.app_state_collection).document(
+          session.app_name
+      )
       user_ref = (
           self.client.collection(self.user_state_collection)
           .document(session.app_name)
@@ -403,8 +364,14 @@ async def append_event(self, session: Session, event: Event) -> Event:
       @firestore.async_transactional  # type: ignore[untyped-decorator]
       async def _append_txn(transaction: firestore.AsyncTransaction) -> None:
         # 1. Reads
-        app_snap = await app_ref.get(transaction=transaction) if app_updates else None
-        user_snap = await user_ref.get(transaction=transaction) if user_updates else None
+        app_snap = (
+            await app_ref.get(transaction=transaction) if app_updates else None
+        )
+        user_snap = (
+            await user_ref.get(transaction=transaction)
+            if user_updates
+            else None
+        )
 
         # 2. Writes
         if app_updates and app_snap is not None:
@@ -429,7 +396,9 @@ async def _append_txn(transaction: firestore.AsyncTransaction) -> None:
         )
 
         event_id = event.id
-        event_ref = session_ref.collection(self.events_collection).document(event_id)
+        event_ref = session_ref.collection(self.events_collection).document(
+            event_id
+        )
         event_data = event.model_dump(exclude_none=True, mode="json")
         transaction.set(
             event_ref,

tests/unittests/integrations/firestore/test_firestore_session_service.py

@@ -577,62 +577,7 @@ async def test_append_event_partial(mock_firestore_client):
 
 
 @pytest.mark.asyncio
-async def test_update_app_state_transactional(mock_firestore_client):
-  service = FirestoreSessionService(client=mock_firestore_client)
-
-  app_name = "test_app"
-  delta = {"new_key": "new_val"}
-
-  transaction = mock.MagicMock()
-  mock_firestore_client.transaction.return_value = transaction
-
-  doc_ref = mock.MagicMock()
-  mock_firestore_client.collection.return_value.document.return_value = doc_ref
-
-  doc_snapshot = mock.MagicMock()
-  doc_snapshot.exists = True
-  doc_snapshot.to_dict.return_value = {"old_key": "old_val"}
-  doc_ref.get = mock.AsyncMock(return_value=doc_snapshot)
-
-  with mock.patch("google.cloud.firestore.async_transactional", lambda x: x):
-    result = await service._update_app_state_transactional(app_name, delta)
-
-  assert result == {"old_key": "old_val", "new_key": "new_val"}
-  transaction.set.assert_called_once_with(
-      doc_ref, {"old_key": "old_val", "new_key": "new_val"}, merge=True
-  )
-
-
-@pytest.mark.asyncio
-async def test_update_user_state_transactional(mock_firestore_client):
-  service = FirestoreSessionService(client=mock_firestore_client)
-
-  app_name = "test_app"
-  user_id = "test_user"
-  delta = {"new_key": "new_val"}
-
-  transaction = mock.MagicMock()
-  mock_firestore_client.transaction.return_value = transaction
 
-  doc_ref = mock.MagicMock()
-  mock_firestore_client.collection.return_value.document.return_value.collection.return_value.document.return_value = (
-      doc_ref
-  )
-
-  doc_snapshot = mock.MagicMock()
-  doc_snapshot.exists = True
-  doc_snapshot.to_dict.return_value = {"old_key": "old_val"}
-  doc_ref.get = mock.AsyncMock(return_value=doc_snapshot)
-
-  with mock.patch("google.cloud.firestore.async_transactional", lambda x: x):
-    result = await service._update_user_state_transactional(
-        app_name, user_id, delta
-    )
-
-  assert result == {"old_key": "old_val", "new_key": "new_val"}
-  transaction.set.assert_called_once_with(
-      doc_ref, {"old_key": "old_val", "new_key": "new_val"}, merge=True
-  )
 
 
 @pytest.mark.asyncio