Commit 4fcedbd
authored
fix: protojson non-determinism in ID generation (#4967)
My tests in #4966 were failing because `protojson` decided it wanted to
add two spaces between the keys and values in its output.
Run the `protojson` output through the `json.Indent` to format it
consistently.
That said, does the formatting of the output actually matter here?
Should we instead rewrite the tests to do a semantic comparison instead
of a string comparison?1 parent dbadc4c commit 4fcedbd
1 file changed
Lines changed: 8 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
221 | 223 | | |
222 | 224 | | |
223 | 225 | | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
| 226 | + | |
230 | 227 | | |
231 | 228 | | |
232 | 229 | | |
233 | 230 | | |
234 | 231 | | |
235 | 232 | | |
236 | 233 | | |
237 | | - | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
238 | 239 | | |
239 | 240 | | |
240 | 241 | | |
| |||
0 commit comments