unittest & feedback

Author: logachev

java-bigquery/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseStruct.java

@@ -21,6 +21,7 @@
 
 import com.google.cloud.bigquery.Field;
 import com.google.cloud.bigquery.FieldList;
+import com.google.cloud.bigquery.StandardSQLTypeName;
 import com.google.cloud.bigquery.exception.BigQueryJdbcSqlFeatureNotSupportedException;
 import java.sql.Date;
 import java.sql.SQLException;
@@ -42,7 +43,7 @@ abstract class BigQueryBaseStruct implements java.sql.Struct {
 
   @Override
   public final String getSQLTypeName() throws SQLException {
-    return "STRUCT";
+    return StandardSQLTypeName.STRUCT.name();
   }
 
   @Override

java-bigquery/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJsonStructTest.java

@@ -246,11 +246,8 @@ public void structWithNullValue() throws SQLException {
   }
 
   @Test
-  public void getSQLTypeNameIsNotSupported() {
-    Exception exception =
-        assertThrows(
-            SQLFeatureNotSupportedException.class, structWithPrimitiveValues::getSQLTypeName);
-    assertThat(exception.getMessage()).isEqualTo(CUSTOMER_TYPE_MAPPING_NOT_SUPPORTED);
+  public void getSQLTypeName() throws SQLException{
+    assertThat(structWithPrimitiveValues.getSQLTypeName()).isEqualTo("STRUCT");
   }
 
   @Test