Skip to content

Commit 3360930

Browse files
committed
test: fix tests in SpanTracerFactoryTest
1 parent 0b6fdd4 commit 3360930

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerFactoryTest.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ class SpanTracerFactoryTest {
6161
private SpanBuilder spanBuilder;
6262
private Span span;
6363

64+
private LibraryMetadata validMetadata;
65+
6466
@BeforeEach
6567
void setUp() {
6668
openTelemetry = mock(OpenTelemetry.class);
@@ -73,6 +75,10 @@ void setUp() {
7375
when(spanBuilder.setSpanKind(any())).thenReturn(spanBuilder);
7476
when(spanBuilder.setAllAttributes(any(Attributes.class))).thenReturn(spanBuilder);
7577
when(spanBuilder.startSpan()).thenReturn(span);
78+
79+
validMetadata = mock(LibraryMetadata.class);
80+
when(validMetadata.artifactName()).thenReturn("gax-java");
81+
when(validMetadata.version()).thenReturn("2.1.0");
7682
}
7783

7884
@ParameterizedTest
@@ -104,7 +110,7 @@ void testNewTracer_addsAttributes(boolean useContext) {
104110
factory =
105111
factory.withContext(
106112
ApiTracerContext.newBuilder()
107-
.setLibraryMetadata(LibraryMetadata.empty())
113+
.setLibraryMetadata(validMetadata)
108114
.setServerAddress("test-address")
109115
.build());
110116
ApiTracer tracerInstance;
@@ -113,7 +119,7 @@ void testNewTracer_addsAttributes(boolean useContext) {
113119
ApiTracerContext.newBuilder()
114120
.setFullMethodName("service/method")
115121
.setTransport(Transport.GRPC)
116-
.setLibraryMetadata(LibraryMetadata.empty())
122+
.setLibraryMetadata(validMetadata)
117123
.build();
118124
tracerInstance = factory.newTracer(null, context);
119125
} else {
@@ -136,7 +142,7 @@ void testNewTracer_addsAttributes(boolean useContext) {
136142
void testWithContext_addsInferredAttributes(boolean useContext) {
137143
ApiTracerContext context =
138144
ApiTracerContext.newBuilder()
139-
.setLibraryMetadata(LibraryMetadata.empty())
145+
.setLibraryMetadata(validMetadata)
140146
.setServerAddress("example.com")
141147
.build();
142148

@@ -150,7 +156,7 @@ void testWithContext_addsInferredAttributes(boolean useContext) {
150156
ApiTracerContext.newBuilder()
151157
.setFullMethodName("service/method")
152158
.setTransport(Transport.GRPC)
153-
.setLibraryMetadata(LibraryMetadata.empty())
159+
.setLibraryMetadata(validMetadata)
154160
.build();
155161
tracerInstance = factoryWithContext.newTracer(null, callContext);
156162
} else {
@@ -174,7 +180,7 @@ void testWithContext_addsInferredAttributes(boolean useContext) {
174180
@ValueSource(booleans = {false, true})
175181
void testWithContext_noEndpointContext_doesNotAddServerAddressAttribute(boolean useContext) {
176182
ApiTracerContext context =
177-
ApiTracerContext.newBuilder().setLibraryMetadata(LibraryMetadata.empty()).build();
183+
ApiTracerContext.newBuilder().setLibraryMetadata(validMetadata).build();
178184

179185
SpanTracerFactory factory =
180186
new SpanTracerFactory(openTelemetry, tracer, ApiTracerContext.empty());
@@ -186,7 +192,7 @@ void testWithContext_noEndpointContext_doesNotAddServerAddressAttribute(boolean
186192
ApiTracerContext.newBuilder()
187193
.setFullMethodName("service/method")
188194
.setTransport(Transport.GRPC)
189-
.setLibraryMetadata(LibraryMetadata.empty())
195+
.setLibraryMetadata(validMetadata)
190196
.build();
191197
tracerInstance = factoryWithContext.newTracer(null, callContext);
192198
} else {

0 commit comments

Comments
 (0)