Skip to content

Commit 514e429

Browse files
committed
libraries_without_api_id
1 parent 9862492 commit 514e429

1 file changed

Lines changed: 16 additions & 11 deletions

File tree

  • sdk-platform-java/hermetic_build/library_generation/utils

sdk-platform-java/hermetic_build/library_generation/utils/utilities.py

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,16 @@
2626
from library_generation.utils.proto_path_utils import remove_version_from
2727

2828
script_dir = os.path.dirname(os.path.realpath(__file__))
29-
SDK_PLATFORM_JAVA = "googleapis/google-cloud-java"
29+
30+
LIBRARIES_WITHOUT_API_ID = {
31+
"google-auth-library",
32+
"showcase",
33+
"iam",
34+
"api-common",
35+
"common-protos",
36+
"gax",
37+
"core",
38+
}
3039

3140

3241
def create_argument(arg_key: str, arg_container: object) -> List[str]:
@@ -179,9 +188,7 @@ def get_library_repository(
179188
180189
:return: string representing the repository
181190
"""
182-
if config.contains_common_protos():
183-
repo = SDK_PLATFORM_JAVA
184-
elif config.is_monorepo():
191+
if config.is_monorepo() or config.contains_common_protos():
185192
repo = "googleapis/google-cloud-java"
186193
else:
187194
repo = f"googleapis/{language}-{library.get_library_name()}"
@@ -242,15 +249,13 @@ def generate_postprocessing_prerequisite_files(
242249
"repo": repo,
243250
"repo_short": f"{language}-{library_name}",
244251
"distribution_name": library.get_maven_coordinate(),
245-
"api_id": api_id,
246-
"library_type": library.library_type,
247-
"requires_billing": library.requires_billing,
248252
}
249253

250-
# this removal is for java-common-protos and java-iam in
251-
# sdk-platform-java
252-
if repo == SDK_PLATFORM_JAVA:
253-
repo_metadata.pop("api_id")
254+
if library.get_library_name() not in LIBRARIES_WITHOUT_API_ID and library.library_type != "OTHER":
255+
repo_metadata["api_id"] = api_id
256+
257+
repo_metadata["library_type"] = library.library_type
258+
repo_metadata["requires_billing"] = library.requires_billing
254259

255260
if library.api_reference:
256261
repo_metadata["api_reference"] = library.api_reference

0 commit comments

Comments
 (0)