Skip to content

Commit 6174892

Browse files
committed
update url.attribute to use appropriate attribute constant
1 parent 87e5287 commit 6174892

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.cloud.bigquery.spi.v2;
1818

19+
import static com.google.cloud.bigquery.telemetry.BigQueryTelemetryTracer.URL_TEMPLATE;
1920
import static java.net.HttpURLConnection.HTTP_CREATED;
2021
import static java.net.HttpURLConnection.HTTP_NOT_FOUND;
2122
import static java.net.HttpURLConnection.HTTP_OK;
@@ -2146,9 +2147,8 @@ private Span createRpcTracingSpan(
21462147
builder.setAllAttributes(otelAttributesFromOptions(options));
21472148
}
21482149

2149-
// Set url.template attribute if available
21502150
if (urlTemplate != null && !urlTemplate.isEmpty()) {
2151-
builder.setAttribute("url.template", urlTemplate);
2151+
builder.setAttribute(URL_TEMPLATE, urlTemplate);
21522152
}
21532153

21542154
return builder.startSpan();

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ private BigQueryTelemetryTracer() {}
6565
public static final AttributeKey<String> SERVER_ADDRESS =
6666
AttributeKey.stringKey("server.address");
6767
public static final AttributeKey<Long> SERVER_PORT = AttributeKey.longKey("server.port");
68+
public static final AttributeKey<String> URL_TEMPLATE = AttributeKey.stringKey("url.template");
69+
6870

6971
public static void addCommonAttributeToSpan(Span span) {
7072
span.setAttribute(GCP_CLIENT_SERVICE, BQ_GCP_CLIENT_SERVICE)

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/HttpTracingRequestInitializer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public class HttpTracingRequestInitializer implements HttpRequestInitializer {
3939
public static final AttributeKey<String> HTTP_REQUEST_METHOD =
4040
AttributeKey.stringKey("http.request.method");
4141
public static final AttributeKey<String> URL_FULL = AttributeKey.stringKey("url.full");
42-
public static final AttributeKey<String> URL_TEMPLATE = AttributeKey.stringKey("url.template");
4342
public static final AttributeKey<String> URL_DOMAIN = AttributeKey.stringKey("url.domain");
4443
public static final AttributeKey<Long> HTTP_RESPONSE_STATUS_CODE =
4544
AttributeKey.longKey("http.response.status_code");

0 commit comments

Comments
 (0)