Skip to content

Commit 721400e

Browse files
committed
fix: format
1 parent 51b930e commit 721400e

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalsMetricsTracer.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@
2929
*/
3030
package com.google.api.gax.tracing;
3131

32-
3332
import com.google.common.annotations.VisibleForTesting;
3433
import com.google.common.base.Stopwatch;
3534
import com.google.common.base.Ticker;
3635
import java.util.HashMap;
3736
import java.util.Map;
37+
import java.util.concurrent.CancellationException;
3838
import java.util.concurrent.TimeUnit;
3939

4040
/**
@@ -82,17 +82,18 @@ public void operationSucceeded() {
8282

8383
@Override
8484
public void operationCancelled() {
85-
ObservabilityUtils.populateStatusAttributes(
86-
attributes, new java.util.concurrent.CancellationException(), transport);
87-
metricsRecorder.recordOperationLatency(
88-
clientRequestTimer.elapsed(TimeUnit.NANOSECONDS) / 1_000_000_000.0, attributes);
85+
recordError(new CancellationException());
8986
}
9087

9188
@Override
9289
public void operationFailed(Throwable error) {
90+
recordError(error);
91+
}
92+
93+
private void recordError(Throwable error) {
94+
ObservabilityUtils.populateStatusAttributes(attributes, error, transport);
9395
attributes.put(
9496
ObservabilityAttributes.ERROR_TYPE_ATTRIBUTE, ObservabilityUtils.extractErrorType(error));
95-
ObservabilityUtils.populateStatusAttributes(attributes, error, transport);
9697
metricsRecorder.recordOperationLatency(
9798
clientRequestTimer.elapsed(TimeUnit.NANOSECONDS) / 1_000_000_000.0, attributes);
9899
}

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/GoldenSignalsMetricsTracerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import static com.google.common.truth.Truth.assertThat;
3434

3535
import com.google.api.gax.rpc.ApiException;
36+
import com.google.api.gax.rpc.LibraryMetadata;
3637
import com.google.api.gax.rpc.StatusCode;
3738
import com.google.api.gax.rpc.testing.FakeStatusCode;
3839
import com.google.common.testing.FakeTicker;

0 commit comments

Comments
 (0)