Skip to content

Commit 83ea75a

Browse files
committed
build: move logback dependencies to jar parent
1 parent a954944 commit 83ea75a

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

generation/check_non_release_please_versions.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ for pomFile in $(find . -mindepth 2 -name pom.xml | sort ); do
1919
[[ "${pomFile}" =~ .*java-storage.* ]] || \
2020
[[ "${pomFile}" =~ .*java-storage-nio.* ]] || \
2121
[[ "${pomFile}" =~ .*java-vertexai.* ]] || \
22-
[[ "${pomFile}" =~ .*java-compute.* ]] || \ # Skip compute due to dependency on logback
2322
[[ "${pomFile}" =~ .*.github*. ]]; then
2423
continue
2524
fi

google-cloud-jar-parent/pom.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,18 @@
7676
<version>4.13.2</version>
7777
<scope>test</scope>
7878
</dependency>
79+
<dependency>
80+
<groupId>ch.qos.logback</groupId>
81+
<artifactId>logback-classic</artifactId>
82+
<version>1.5.25</version>
83+
<scope>test</scope>
84+
</dependency>
85+
<dependency>
86+
<groupId>ch.qos.logback</groupId>
87+
<artifactId>logback-core</artifactId>
88+
<version>1.5.25</version>
89+
<scope>test</scope>
90+
</dependency>
7991
<dependency>
8092
<groupId>joda-time</groupId>
8193
<artifactId>joda-time</artifactId>

java-compute/google-cloud-compute/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,11 @@
117117
<dependency>
118118
<groupId>ch.qos.logback</groupId>
119119
<artifactId>logback-classic</artifactId>
120-
<version>1.5.25</version>
121120
<scope>test</scope>
122121
</dependency>
123122
<dependency>
124123
<groupId>ch.qos.logback</groupId>
125124
<artifactId>logback-core</artifactId>
126-
<version>1.5.25</version>
127125
<scope>test</scope>
128126
</dependency>
129127
<dependency>

0 commit comments

Comments
 (0)