Skip to content

Commit 9ad747d

Browse files
committed
remove double fomatting messages
1 parent f0c43cc commit 9ad747d

5 files changed

Lines changed: 9 additions & 18 deletions

File tree

java-bigquery/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseArray.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,7 @@ protected Tuple<Integer, Integer> createRange(long index, int count, int size)
146146
String.format(
147147
"The array index is out of range: %d, number of elements: %d.",
148148
index + count, size));
149-
LOG.severe(
150-
ex, "The array index is out of range: %d, number of elements: %d.", index + count, size);
149+
LOG.severe(ex, ex.getMessage());
151150
throw ex;
152151
}
153152
long toIndex = normalisedFromIndex + count;

java-bigquery/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDriver.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public class BigQueryDriver implements Driver {
6666
} catch (SQLException e) {
6767
ExceptionInInitializerError ex =
6868
new ExceptionInInitializerError("Registering driver failed: " + e.getMessage());
69-
LOG.severe(ex, "Registering driver failed: " + e.getMessage());
69+
LOG.severe(ex, ex.getMessage());
7070
throw ex;
7171
}
7272
LoadBalancerRegistry.getDefaultRegistry().register(new PickFirstLoadBalancerProvider());
@@ -101,9 +101,7 @@ public static BigQueryDriver getRegisteredDriver() throws IllegalStateException
101101
IllegalStateException ex =
102102
new IllegalStateException(
103103
"Driver is not registered (or it has not been registered using Driver.register() method)");
104-
LOG.severe(
105-
ex,
106-
"Driver is not registered (or it has not been registered using Driver.register() method)");
104+
LOG.severe(ex, ex.getMessage());
107105
throw ex;
108106
}
109107

@@ -196,7 +194,7 @@ public boolean acceptsURL(String url) throws SQLException {
196194
LOG.finest("++enter++");
197195
if (url == null || url.isEmpty()) {
198196
BigQueryJdbcException ex = new BigQueryJdbcException("Connection URL is null.");
199-
LOG.severe(ex, "Connection URL is null.");
197+
LOG.severe(ex, ex.getMessage());
200198
throw ex;
201199
}
202200
return url.startsWith("jdbc:bigquery:");

java-bigquery/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcProxyUtility.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ static Map<String, String> parseProxyProperties(DataSource ds, String callerClas
7676
String.format(
7777
"Illegal port number provided %s. Please provide a valid port number.",
7878
proxyPort));
79-
LOG.severe(
80-
ex, "Illegal port number provided %s. Please provide a valid port number.", proxyPort);
79+
LOG.severe(ex, ex.getMessage());
8180
throw ex;
8281
}
8382
proxyProperties.put(BigQueryJdbcUrlUtility.PROXY_PORT_PROPERTY_NAME, proxyPort);

java-bigquery/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcUrlUtility.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,7 @@ private static Map<String, String> parseUrlInternal(String url) {
709709
BigQueryJdbcRuntimeException ex =
710710
new BigQueryJdbcRuntimeException(
711711
String.format("Wrong value or unknown setting: %s", safeRef));
712-
LOG.severe(ex, "Wrong value or unknown setting: %s", safeRef);
712+
LOG.severe(ex, ex.getMessage());
713713
throw ex;
714714
} else {
715715
LOG.warning("Wrong value or unknown setting: %s", safeRef);
@@ -779,10 +779,7 @@ static boolean convertIntToBoolean(String value, String propertyName) {
779779
"Invalid value for %s. For Boolean connection properties, use 0 for false and 1 for"
780780
+ " true.",
781781
propertyName));
782-
LOG.severe(
783-
ex,
784-
"Invalid value for %s. For Boolean connection properties, use 0 for false and 1 for true.",
785-
propertyName);
782+
LOG.severe(ex, ex.getMessage());
786783
throw ex;
787784
}
788785
}

java-bigquery/google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/DataSource.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,16 +371,14 @@ public Connection getConnection() throws SQLException {
371371
BigQueryJdbcException ex =
372372
new BigQueryJdbcException(
373373
"Connection URL is null. Please specify a valid Connection URL to get Connection.");
374-
LOG.severe(
375-
ex, "Connection URL is null. Please specify a valid Connection URL to get Connection.");
374+
LOG.severe(ex, ex.getMessage());
376375
throw ex;
377376
}
378377
if (!BigQueryDriver.getRegisteredDriver().acceptsURL(getURL())) {
379378
BigQueryJdbcException ex =
380379
new BigQueryJdbcException(
381380
"The URL " + getURL() + " is invalid. Please specify a valid Connection URL. ");
382-
LOG.severe(
383-
ex, "The URL " + getURL() + " is invalid. Please specify a valid Connection URL. ");
381+
LOG.severe(ex, ex.getMessage());
384382
throw ex;
385383
}
386384
return DriverManager.getConnection(getURL(), createProperties());

0 commit comments

Comments
 (0)