Skip to content

Commit a4b9949

Browse files
committed
PR feedback
1 parent 713c745 commit a4b9949

3 files changed

Lines changed: 18 additions & 19 deletions

File tree

java-bigquery/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,13 @@
110110
<type>pom</type>
111111
<scope>import</scope>
112112
</dependency>
113+
<dependency>
114+
<groupId>io.netty</groupId>
115+
<artifactId>netty-bom</artifactId>
116+
<version>4.1.132.Final</version>
117+
<type>pom</type>
118+
<scope>import</scope>
119+
</dependency>
113120
</dependencies>
114121
</dependencyManagement>
115122

sdk-platform-java/gax-java/dependencies.properties

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ maven.io_opencensus_opencensus_api=io.opencensus:opencensus-api:0.31.1
4545
maven.io_opencensus_opencensus_contrib_grpc_metrics=io.opencensus:opencensus-contrib-grpc-metrics:0.31.1
4646
maven.io_opencensus_opencensus_contrib_http_util=io.opencensus:opencensus-contrib-http-util:0.31.1
4747
maven.io_netty_netty_tcnative_boringssl_static=io.netty:netty-tcnative-boringssl-static:2.0.70.Final
48-
maven.io_netty_netty_handler=io.netty:netty-handler:4.1.132.Final
49-
maven.io_netty_netty_common=io.netty:netty-common:4.1.132.Final
50-
maven.io_netty_netty_codec_socks=io.netty:netty-codec-socks:4.1.132.Final
51-
maven.io_netty_netty_codec_http2=io.netty:netty-codec-http2:4.1.132.Final
52-
maven.io_netty_netty_codec_http=io.netty:netty-codec-http:4.1.132.Final
53-
maven.io_netty_netty_codec=io.netty:netty-codec:4.1.132.Final
54-
maven.io_netty_netty_buffer=io.netty:netty-buffer:4.1.132.Final
55-
maven.io_netty_netty_resolver=io.netty:netty-resolver:4.1.132.Final
56-
maven.io_netty_netty_transport=io.netty:netty-transport:4.1.132.Final
57-
maven.io_netty_netty_handler_proxy=io.netty:netty-handler-proxy:4.1.132.Final
58-
maven.io_netty_netty_transport_native_unix_common=io.netty:netty-transport-native-unix-common:4.1.132.Final
48+
maven.io_netty_netty_handler=io.netty:netty-handler:4.1.118.Final
49+
maven.io_netty_netty_common=io.netty:netty-common:4.1.118.Final
50+
maven.io_netty_netty_codec_socks=io.netty:netty-codec-socks:4.1.118.Final
51+
maven.io_netty_netty_codec_http2=io.netty:netty-codec-http2:4.1.118.Final
52+
maven.io_netty_netty_codec_http=io.netty:netty-codec-http:4.1.118.Final
53+
maven.io_netty_netty_codec=io.netty:netty-codec:4.1.118.Final
54+
maven.io_netty_netty_buffer=io.netty:netty-buffer:4.1.118.Final
55+
maven.io_netty_netty_resolver=io.netty:netty-resolver:4.1.118.Final
56+
maven.io_netty_netty_transport=io.netty:netty-transport:4.1.118.Final
57+
maven.io_netty_netty_handler_proxy=io.netty:netty-handler-proxy:4.1.118.Final
58+
maven.io_netty_netty_transport_native_unix_common=io.netty:netty-transport-native-unix-common:4.1.118.Final
5959
maven.io_perfmark_perfmark_api=io.perfmark:perfmark-api:0.27.0
6060
maven.org_apache_tomcat_annotations_api=org.apache.tomcat:annotations-api:6.0.53
6161
maven.com_google_code_gson_gson=com.google.code.gson:gson:2.12.1

sdk-platform-java/java-shared-dependencies/third-party-dependencies/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
<com.google.crypto.tink.version>1.16.0</com.google.crypto.tink.version>
4646
<io.opentelemetry.contrib.opentelemetry-gcp-resources.version>1.45.0-alpha</io.opentelemetry.contrib.opentelemetry-gcp-resources.version>
4747
<json.version>20250517</json.version>
48-
<netty.version>4.1.132.Final</netty.version>
4948
</properties>
5049

5150
<dependencyManagement>
@@ -263,13 +262,6 @@
263262
<artifactId>tink</artifactId>
264263
<version>${com.google.crypto.tink.version}</version>
265264
</dependency>
266-
<dependency>
267-
<groupId>io.netty</groupId>
268-
<artifactId>netty-bom</artifactId>
269-
<version>${netty.version}</version>
270-
<type>pom</type>
271-
<scope>import</scope>
272-
</dependency>
273265
</dependencies>
274266
</dependencyManagement>
275267
</project>

0 commit comments

Comments
 (0)