added issue tracking and updated strings to use hardcoded vars

Author: ldetmer

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java

@@ -1788,8 +1788,10 @@ private static Attributes otelAttributesFromOptions(Map<Option, ?> options) {
     return builder.build();
   }
 
-  /* Temporary development gate for HttpTracingRequestInitializer rollout:
-  must be explicitly enabled with the system property
+  /**
+   * Temporary development gate for HttpTracingRequestInitializer rollout: must be explicitly
+   * enabled with the system property. tracking ticket for removal:
+   * https://github.com/googleapis/google-cloud-java/issues/12100
    */
   static boolean isHttpTracingEnabled() {
     return Boolean.parseBoolean(System.getProperty(HTTP_TRACING_DEV_GATE_PROPERTY));

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracer.java

@@ -33,6 +33,8 @@ private BigQueryTelemetryTracer() {}
   public static final String BQ_GCP_CLIENT_ARTIFACT = "google-cloud-bigquery";
   public static final String BQ_GCP_CLIENT_LANGUAGE = "java";
 
+  // TODO: migrate to use gax attributes keys
+  // https://github.com/googleapis/google-cloud-java/issues/12099
   // Common GCP Attributes
   public static final AttributeKey<String> GCP_CLIENT_SERVICE =
       AttributeKey.stringKey("gcp.client.service");

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/HttpTracingRequestInitializer.java

@@ -33,6 +33,8 @@
 @InternalApi
 public class HttpTracingRequestInitializer implements HttpRequestInitializer {
 
+  // TODO: migrate to use gax attributes keys
+  // https://github.com/googleapis/google-cloud-java/issues/12099
   // HTTP Specific Telemetry Attributes
   public static final AttributeKey<String> HTTP_REQUEST_METHOD =
       AttributeKey.stringKey("http.request.method");

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpcTest.java

@@ -18,6 +18,7 @@
 import static com.google.common.truth.Truth.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -44,6 +45,8 @@
 import com.google.api.services.bigquery.model.TableReference;
 import com.google.cloud.NoCredentials;
 import com.google.cloud.bigquery.BigQueryOptions;
+import com.google.cloud.bigquery.telemetry.BigQueryTelemetryTracer;
+import com.google.cloud.bigquery.telemetry.HttpTracingRequestInitializer;
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.trace.Tracer;
 import io.opentelemetry.sdk.OpenTelemetrySdk;
@@ -943,9 +946,8 @@ public void testHttpTracingEnabledAddsAdditionalAttributes() throws Exception {
                 .findFirst()
                 .orElse(null);
         assertNotNull(rpcSpan);
-        assertEquals(
-            "http", rpcSpan.getAttributes().get(AttributeKey.stringKey("rpc.system.name")));
-        assertNotNull(rpcSpan.getAttributes().get(AttributeKey.stringKey("server.address")));
+        assertEquals("http", rpcSpan.getAttributes().get(BigQueryTelemetryTracer.RPC_SYSTEM_NAME));
+        assertNotNull(rpcSpan.getAttributes().get(HttpTracingRequestInitializer.URL_DOMAIN));
       } finally {
         System.clearProperty("com.google.cloud.bigquery.http.tracing.dev.enabled");
       }
@@ -987,8 +989,8 @@ public void testHttpTracingDisabledDoesNotAddAdditionalAttributes() throws Excep
                 .findFirst()
                 .orElse(null);
         assertNotNull(rpcSpan);
-        assertThat(rpcSpan.getAttributes().get(AttributeKey.stringKey("rpc.system.name"))).isNull();
-        assertThat(rpcSpan.getAttributes().get(AttributeKey.stringKey("server.address"))).isNull();
+        assertNull(rpcSpan.getAttributes().get(BigQueryTelemetryTracer.RPC_SYSTEM_NAME));
+        assertNull(rpcSpan.getAttributes().get(HttpTracingRequestInitializer.URL_DOMAIN));
       } finally {
         System.clearProperty("com.google.cloud.bigquery.http.tracing.dev.enabled");
       }