Commit cd0d671
committed
test(logging): fix missing exception in clientLevelFailureAttributes tests
Changed the endpoint for `testHttpJson_clientLevelFailureAttributes` and `testGrpc_clientLevelFailureAttributes` to `localhost:1` instead of `DEFAULT_HTTPJSON_ENDPOINT` and `DEFAULT_GRPC_ENDPOINT`.
Since the showcase server is running during integration tests, sending an empty `EchoRequest` to the default endpoint succeeds without throwing an `ApiException`, causing the `assertThrows` assertion to fail. By pointing to a bad endpoint, we ensure a network exception is always thrown and the client-level failure attributes are properly populated and logged.1 parent 483e589 commit cd0d671
1 file changed
Lines changed: 2 additions & 2 deletions
File tree
- sdk-platform-java/java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/logging
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
219 | | - | |
| 219 | + | |
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
| 271 | + | |
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
| |||
0 commit comments