Skip to content

Commit d05b612

Browse files
committed
chore: Update comments in the ITs
1 parent 2c13e0d commit d05b612

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ public void close() throws Exception {
186186
} catch (Exception e) {
187187
logger.log(Level.WARNING, "Failed to close channels", e);
188188
}
189-
// Flush and shut down the built-in OTel SDK if active; no-op for user-provided instances.
189+
// Shut down the built-in OTel SDK as we manage its lifecycle
190190
if (builtInOpenTelemetry instanceof OpenTelemetrySdk) {
191191
try {
192192
((OpenTelemetrySdk) builtInOpenTelemetry).close();

java-datastore/google-cloud-datastore/src/test/java/com/google/cloud/datastore/ITDatastoreBuiltInAndCustomMetrics.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,8 @@ public void setUp() {
106106
OpenTelemetrySdk customOtel =
107107
OpenTelemetrySdk.builder().setMeterProvider(customMeterProvider).build();
108108

109-
// Configure the Datastore client with BOTH backends active:
110-
// 1. Built-in Cloud Monitoring export (enabled by default via
111-
// DatastoreOpenTelemetryOptions.exportBuiltinMetricsToGoogleCloudMonitoring = true)
112-
// 2. User-configured OTel backend wired to the in-memory reader above.
113-
//
114-
// The resulting DatastoreMetricsRecorder will be a CompositeDatastoreMetricsRecorder that
115-
// fans out all recording calls to both backends simultaneously.
109+
// Do not enable setExportBuiltinMetricsToGoogleCloudMonitoring(false) for this IT
110+
// as we will only rely on in-memory to collect the metrics for this test
116111
DatastoreOptions.Builder builder =
117112
DatastoreOptions.newBuilder()
118113
.setProjectId(PROJECT_ID)

0 commit comments

Comments
 (0)