Skip to content

Commit dbb05b3

Browse files
committed
renamed GCP_DESTINATION_ID to more explicit GCP_RESOURCE_DESTINATION_ID
1 parent bc84c49 commit dbb05b3

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2061,7 +2061,7 @@ private Span createRpcTracingSpan(
20612061
.setAttribute("bq.rpc.service", service)
20622062
.setAttribute("bq.rpc.method", method)
20632063
.setAttribute("bq.rpc.system", "http")
2064-
.setAttribute(BigQueryTelemetryTracer.GCP_DESTINATION_ID, gcpResourceDestinationId);
2064+
.setAttribute(BigQueryTelemetryTracer.GCP_RESOURCE_DESTINATION_ID, gcpResourceDestinationId);
20652065

20662066
if (options != null) {
20672067
builder.setAllAttributes(otelAttributesFromOptions(options));

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private BigQueryTelemetryTracer() {}
4949
AttributeKey.stringKey("gcp.client.artifact");
5050
public static final AttributeKey<String> GCP_CLIENT_LANGUAGE =
5151
AttributeKey.stringKey("gcp.client.language");
52-
public static final AttributeKey<String> GCP_DESTINATION_ID =
52+
public static final AttributeKey<String> GCP_RESOURCE_DESTINATION_ID =
5353
AttributeKey.stringKey("gcp.resource.destination.id");
5454
public static final AttributeKey<String> RPC_SYSTEM_NAME =
5555
AttributeKey.stringKey("rpc.system.name");

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpcTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ private void verifySpan(
156156
assertEquals("http", rpcSpan.getAttributes().get(AttributeKey.stringKey("bq.rpc.system")));
157157

158158
assertEquals(
159-
gcpResourceDestinationId, rpcSpan.getAttributes().get(BigQueryTelemetryTracer.GCP_DESTINATION_ID));
159+
gcpResourceDestinationId, rpcSpan.getAttributes().get(BigQueryTelemetryTracer.GCP_RESOURCE_DESTINATION_ID));
160160

161161
if (attributes != null) {
162162
for (Map.Entry<String, String> entry : attributes.entrySet()) {

0 commit comments

Comments
 (0)