fix: address PR feedback and update dataplex changelog

- Update override parser to preserve newlines in multi-line commit messages
  (e.g., for breaking changes) instead of squashing them into single lines.
- Update test suite to use `sys.executable` for cross-platform portability
  and `capture_output=True` for idiomatic subprocess calls.
- Regenerate test goldens to reflect the corrected multi-line markdown output.
- Update java-dataplex/CHANGELOG.md to reflect the corrected output.

Author: meltsufin

.github/release-note-generation/generate_module_notes.py

@@ -114,7 +114,7 @@ def parse_commit_overrides(commit_data, short_name, prefix_regex, commit_hash, c
 
         if is_new_item:
             if in_module_item and current_item:
-                categorize_callback(commit_hash, " ".join(current_item))
+                categorize_callback(commit_hash, "\n".join(current_item))
                 current_item = []
                 in_module_item = False
 
@@ -136,7 +136,7 @@ def parse_commit_overrides(commit_data, short_name, prefix_regex, commit_hash, c
             current_item.append(line_stripped)
 
     if in_module_item and current_item:
-        categorize_callback(commit_hash, " ".join(current_item))
+        categorize_callback(commit_hash, "\n".join(current_item))
 
     return True
 

.github/release-note-generation/test_generate_module_notes.py

@@ -1,4 +1,5 @@
 import subprocess
+import sys
 import unittest
 from pathlib import Path
 
@@ -17,7 +18,7 @@ def test_java_run_generation(self):
             expected_output = f.read()
 
         cmd = [
-            "python3",
+            sys.executable,
             str(self.script_path),
             "--module",
             "google-cloud-run",
@@ -29,10 +30,9 @@ def test_java_run_generation(self):
             "run",
         ]
         result = subprocess.run(
-            cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True
+            cmd, capture_output=True, text=True, check=True
         )
 
-        self.assertEqual(result.returncode, 0)
         self.assertEqual(result.stdout, expected_output)
 
     def test_root_generation(self):
@@ -41,7 +41,7 @@ def test_root_generation(self):
             expected_output = f.read()
 
         cmd = [
-            "python3",
+            sys.executable,
             str(self.script_path),
             "--module",
             "google-cloud-java",
@@ -51,10 +51,9 @@ def test_root_generation(self):
             "1.85.0",
         ]
         result = subprocess.run(
-            cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True
+            cmd, capture_output=True, text=True, check=True
         )
 
-        self.assertEqual(result.returncode, 0)
         self.assertEqual(result.stdout, expected_output)
 
 
@@ -67,11 +66,10 @@ def test_java_dataplex_generation(self):
             "--short-name", "dataplex"
         ]
 
-        cmd = ["python3", str(self.script_path)] + args
+        cmd = [sys.executable, str(self.script_path)] + args
         result = subprocess.run(
-            cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True
+            cmd, capture_output=True, text=True, check=True
         )
-        self.assertEqual(result.returncode, 0)
 
         golden_path = self.testdata_dir / "golden_java-dataplex_1.86.0.txt"
         with open(golden_path, "r") as f:

.github/release-note-generation/testdata/golden_java-dataplex_1.86.0.txt

@@ -2,21 +2,49 @@
 
 ### ⚠ BREAKING CHANGES
 
-* fix(dataplex)!: remove deprecated Explore-related methods and messages from public client libraries Breaking Changes: - Removed ContentService and all associated methods (CreateContent, UpdateContent, DeleteContent, GetContent, ListContent, etc.) and request/response messages. - Removed Environment and Session management methods from DataplexService (CreateEnvironment, UpdateEnvironment, DeleteEnvironment, ListEnvironments, GetEnvironment, ListSessions) and their associated messages. [googleapis/googleapis@69ca7ae](https://github.com/googleapis/googleapis/commit/69ca7ae2e66cd5623cafecc00971ef5397a4b258) ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* fix(dataplex)!: remove deprecated Explore-related methods and messages
+from public client libraries
+Breaking Changes:
+- Removed ContentService and all associated methods (CreateContent,
+UpdateContent, DeleteContent, GetContent, ListContent, etc.) and
+request/response messages.
+- Removed Environment and Session management methods from
+DataplexService (CreateEnvironment, UpdateEnvironment,
+DeleteEnvironment, ListEnvironments, GetEnvironment, ListSessions) and
+their associated messages.
+[googleapis/googleapis@69ca7ae](https://github.com/googleapis/googleapis/commit/69ca7ae2e66cd5623cafecc00971ef5397a4b258) ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 
 ### Features
 
-* feat(dataplex): add DataProductService to manage data products and underlying data assets ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
-* feat(dataplex): add MetadataFeed to CatalogService for tracking metadata changes ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
-* feat(dataplex): add LookupContext to CatalogService for LLM-generated resource context ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* feat(dataplex): add DataProductService to manage data products and
+underlying data assets ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* feat(dataplex): add MetadataFeed to CatalogService for tracking metadata
+changes ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* feat(dataplex): add LookupContext to CatalogService for LLM-generated
+resource context ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 * feat(dataplex): add support for attaching aspects to EntryLinks ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
-* feat(dataplex): add UpdateEntryLink and LookupEntryLinks methods to CatalogService ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* feat(dataplex): add UpdateEntryLink and LookupEntryLinks methods to
+CatalogService ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 * feat(dataplex): support OneTime triggers for DataScan operations ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 * feat(dataplex): add debug query support to Data Quality rules ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
-* feat(dataplex): allow selective generation scope for Data Documentation scans ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* feat(dataplex): allow selective generation scope for Data Documentation
+scans ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 * feat(dataplex): add SKIPPED state to DataScan catalog publishing status ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 
 ### Documentation
 
-* docs(dataplex): remove deprecated metadata change warnings in Dataplex Catalog The DataProductService provides APIs to curate and manage collections of data assets as data products, enabling more organized sharing and usage for specific business cases. MetadataFeeds allow users to monitor metadata changes (CREATE, UPDATE, DELETE) within a specified scope (organization, project, or entry group) and publish them to Pub/Sub. CatalogService now includes a LookupContext API to provide LLM-generated context for resources, and enhanced EntryLink management, including the ability to attach aspects. DataScan operations now support a OneTime trigger for single-run scans, and Data Quality rules support DebugQueries to help investigate rule failures by returning diagnostic values. ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
+* docs(dataplex): remove deprecated metadata change warnings in Dataplex
+Catalog
+The DataProductService provides APIs to curate and manage collections of
+data assets as data products, enabling more organized sharing and usage
+for specific business cases.
+MetadataFeeds allow users to monitor metadata changes (CREATE, UPDATE,
+DELETE) within a specified scope (organization, project, or entry group)
+and publish them to Pub/Sub.
+CatalogService now includes a LookupContext API to provide LLM-generated
+context for resources, and enhanced EntryLink management, including the
+ability to attach aspects.
+DataScan operations now support a OneTime trigger for single-run scans,
+and Data Quality rules support DebugQueries to help investigate rule
+failures by returning diagnostic values. ([e29dd99](https://github.com/googleapis/google-cloud-java/commit/e29dd99559b04de62d2f91792a6352b5ce980438))
 

.github/release-note-generation/testdata/golden_java-run_0.71.0.txt

@@ -2,11 +2,19 @@
 
 ### ⚠ BREAKING CHANGES
 
-* fix!: [run] An existing resource_definition `cloudbuild.googleapis.com/WorkerPool` is removed ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
-* fix!: [run] A type of an existing resource_reference option of the field `worker_pool` in message `.google.cloud.run.v2.SubmitBuildRequest` is changed from `cloudbuild.googleapis.com/WorkerPool` to `cloudbuild.googleapis.com/BuildWorkerPool` ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
-* fix!: [run] A type of an existing resource_reference option of the field `worker_pool` in message `.google.cloud.run.v2.BuildConfig` is changed from `cloudbuild.googleapis.com/WorkerPool` to `cloudbuild.googleapis.com/BuildWorkerPool` ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
+* fix!: [run] An existing resource_definition
+`cloudbuild.googleapis.com/WorkerPool` is removed ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
+* fix!: [run] A type of an existing resource_reference option of the field
+`worker_pool` in message `.google.cloud.run.v2.SubmitBuildRequest` is
+changed from `cloudbuild.googleapis.com/WorkerPool` to
+`cloudbuild.googleapis.com/BuildWorkerPool` ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
+* fix!: [run] A type of an existing resource_reference option of the field
+`worker_pool` in message `.google.cloud.run.v2.BuildConfig` is changed
+from `cloudbuild.googleapis.com/WorkerPool` to
+`cloudbuild.googleapis.com/BuildWorkerPool` ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
 
 ### Features
 
-* feat: [run] Adding new resource tpye run.googleapis.com/WorkerPool. [googleapis/googleapis@0998e04](https://github.com/googleapis/googleapis/commit/0998e045cf83a1307ceb158e3da304bdaff5bb3a) ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))
+* feat: [run] Adding new resource tpye run.googleapis.com/WorkerPool.
+[googleapis/googleapis@0998e04](https://github.com/googleapis/googleapis/commit/0998e045cf83a1307ceb158e3da304bdaff5bb3a) ([9f28cd5](https://github.com/googleapis/google-cloud-java/commit/9f28cd5bcd951333fb2a3847edba015840b5029b))