fix: rename

Author: blakeli0

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalsMetricsTracer.java

@@ -75,22 +75,22 @@ class GoldenSignalsMetricsTracer implements ApiTracer {
    */
   @Override
   public void operationSucceeded() {
-    recordError(null);
+    recordMetric(null);
   }
 
   @Override
   public void operationCancelled() {
-    recordError(new CancellationException());
+    recordMetric(new CancellationException());
   }
 
   @Override
   public void operationFailed(Throwable error) {
-    recordError(error);
+    recordMetric(error);
   }
 
-  private void recordError(Throwable error) {
+  private void recordMetric(Throwable error) {
     Map<String, Object> errorAttributes =
-        ObservabilityUtils.getErrorAttributes(error, transport);
+        ObservabilityUtils.getResponseAttributes(error, transport);
     attributes.putAll(errorAttributes);
     metricsRecorder.recordOperationLatency(
         clientRequestTimer.elapsed(TimeUnit.NANOSECONDS) / 1_000_000_000.0, attributes);

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/ObservabilityUtils.java

@@ -171,7 +171,7 @@ private static String redactSensitiveQueryValues(final String rawQuery) {
     return Joiner.on('&').join(redactedParams);
   }
 
-  static Map<String, Object> getErrorAttributes(
+  static Map<String, Object> getResponseAttributes(
       @Nullable Throwable error, ApiTracerContext.Transport transport) {
     Map<String, Object> attributes = new HashMap<>();
     StatusCode.Code code = extractStatus(error);

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracer.java

@@ -218,7 +218,7 @@ private void recordErrorAndEndAttempt(Throwable error) {
       return;
     }
     Map<String, Object> errorAttributes =
-        ObservabilityUtils.getErrorAttributes(error, this.apiTracerContext.transport());
+        ObservabilityUtils.getResponseAttributes(error, this.apiTracerContext.transport());
     if (!errorAttributes.isEmpty()) {
       attemptSpan.setAllAttributes(ObservabilityUtils.toOtelAttributes(errorAttributes));
     }

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/ObservabilityUtilsTest.java

@@ -115,44 +115,44 @@ void testToOtelAttributes_shouldMapIntAttributes() {
   }
 
   @Test
-  void testGetErrorAttributes_grpc_success() {
+  void testGetResponseAttributes_grpc_success() {
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(null, ApiTracerContext.Transport.GRPC);
+        ObservabilityUtils.getResponseAttributes(null, ApiTracerContext.Transport.GRPC);
     assertThat(attributes)
         .containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "OK");
   }
 
   @Test
-  void testGetErrorAttributes_grpc_apiException() {
+  void testGetResponseAttributes_grpc_apiException() {
     ApiException error =
         new ApiException("fake_error", null, new FakeStatusCode(StatusCode.Code.NOT_FOUND), false);
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(error, ApiTracerContext.Transport.GRPC);
+        ObservabilityUtils.getResponseAttributes(error, ApiTracerContext.Transport.GRPC);
     assertThat(attributes)
         .containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "NOT_FOUND");
   }
 
   @Test
-  void testGetErrorAttributes_grpc_cancellationException() {
+  void testGetResponseAttributes_grpc_cancellationException() {
     Throwable error = new java.util.concurrent.CancellationException();
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(error, ApiTracerContext.Transport.GRPC);
+        ObservabilityUtils.getResponseAttributes(error, ApiTracerContext.Transport.GRPC);
     assertThat(attributes)
         .containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "CANCELLED");
   }
 
   @Test
-  void testGetErrorAttributes_http_success() {
+  void testGetResponseAttributes_http_success() {
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(null, ApiTracerContext.Transport.HTTP);
+        ObservabilityUtils.getResponseAttributes(null, ApiTracerContext.Transport.HTTP);
     assertThat(attributes)
         .containsEntry(
             ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE,
             (long) StatusCode.Code.OK.getHttpStatusCode());
   }
 
   @Test
-  void testGetErrorAttributes_http_apiExceptionWithIntegerTransportCode() {
+  void testGetResponseAttributes_http_apiExceptionWithIntegerTransportCode() {
     ApiException error =
         new ApiException(
             "fake_error",
@@ -170,15 +170,15 @@ public Object getTransportCode() {
             },
             false);
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(error, ApiTracerContext.Transport.HTTP);
+        ObservabilityUtils.getResponseAttributes(error, ApiTracerContext.Transport.HTTP);
     assertThat(attributes)
         .containsEntry(
             ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE,
             (long) StatusCode.Code.NOT_FOUND.getHttpStatusCode());
   }
 
   @Test
-  void testGetErrorAttributes_http_apiExceptionWithNonIntegerTransportCode() {
+  void testGetResponseAttributes_http_apiExceptionWithNonIntegerTransportCode() {
     ApiException error =
         new ApiException(
             "fake_error",
@@ -196,18 +196,18 @@ public Object getTransportCode() {
             },
             false);
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(error, ApiTracerContext.Transport.HTTP);
+        ObservabilityUtils.getResponseAttributes(error, ApiTracerContext.Transport.HTTP);
     assertThat(attributes)
         .containsEntry(
             ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE,
             (long) StatusCode.Code.NOT_FOUND.getHttpStatusCode());
   }
 
   @Test
-  void testGetErrorAttributes_http_cancellationException() {
+  void testGetResponseAttributes_http_cancellationException() {
     Throwable error = new java.util.concurrent.CancellationException();
     Map<String, Object> attributes =
-        ObservabilityUtils.getErrorAttributes(error, ApiTracerContext.Transport.HTTP);
+        ObservabilityUtils.getResponseAttributes(error, ApiTracerContext.Transport.HTTP);
     assertThat(attributes)
         .containsEntry(
             ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE,