fix: fixed code quality issues (#398)

* Add .deepsource.toml

* Fixed Object Inheritance

* Replace ternary syntax with if expression

* Use literal syntax to create data structure

Author: HarshCasper

.deepsource.toml

@@ -0,0 +1,10 @@
+version = 1
+
+test_patterns = ["tests/**"]
+
+[[analyzers]]
+name = "python"
+enabled = true
+
+  [analyzers.meta]
+  runtime_version = "3.x.x"

googlemaps/client.py

@@ -43,10 +43,10 @@
 _USER_AGENT = "GoogleGeoApiClientPython/%s" % googlemaps.__version__
 _DEFAULT_BASE_URL = "https://maps.googleapis.com"
 
-_RETRIABLE_STATUSES = set([500, 503, 504])
+_RETRIABLE_STATUSES = {500, 503, 504}
 
 
-class Client(object):
+class Client:
     """Performs requests to the Google Maps API web services."""
 
     def __init__(self, key=None, client_id=None, client_secret=None,

googlemaps/convert.py

@@ -160,9 +160,7 @@ def _is_list(arg):
         return False
     if isinstance(arg, str): # Python 3-only, as str has __iter__
         return False
-    return (not _has_method(arg, "strip")
-            and _has_method(arg, "__getitem__")
-            or _has_method(arg, "__iter__"))
+    return _has_method(arg, "__getitem__") if not _has_method(arg, "strip") else _has_method(arg, "__iter__")
 
 
 def is_string(val):

googlemaps/maps.py

@@ -20,16 +20,11 @@
 from googlemaps import convert
 
 
-MAPS_IMAGE_FORMATS = set(
-    ['png8', 'png', 'png32', 'gif', 'jpg', 'jpg-baseline']
-)
+MAPS_IMAGE_FORMATS = {'png8', 'png', 'png32', 'gif', 'jpg', 'jpg-baseline'}
 
-MAPS_MAP_TYPES = set(
-    ['roadmap', 'satellite', 'terrain', 'hybrid']
-)
+MAPS_MAP_TYPES = {'roadmap', 'satellite', 'terrain', 'hybrid'}
 
-
-class StaticMapParam(object):
+class StaticMapParam:
     """Base class to handle parameters for Maps Static API."""
 
     def __init__(self):

googlemaps/places.py

@@ -21,9 +21,7 @@
 from googlemaps import convert
 
 
-PLACES_FIND_FIELDS_BASIC = set(
-    [
-        "business_status",
+PLACES_FIND_FIELDS_BASIC = {"business_status",
         "formatted_address",
         "geometry",
         "geometry/location",
@@ -42,23 +40,19 @@
         "photos",
         "place_id",
         "plus_code",
-        "types",
-    ]
-)
+        "types",}
 
-PLACES_FIND_FIELDS_CONTACT = set(["opening_hours"])
+PLACES_FIND_FIELDS_CONTACT = {"opening_hours"}
 
-PLACES_FIND_FIELDS_ATMOSPHERE = set(["price_level", "rating", "user_ratings_total"])
+PLACES_FIND_FIELDS_ATMOSPHERE = {"price_level", "rating", "user_ratings_total"}
 
 PLACES_FIND_FIELDS = (
     PLACES_FIND_FIELDS_BASIC
     ^ PLACES_FIND_FIELDS_CONTACT
     ^ PLACES_FIND_FIELDS_ATMOSPHERE
 )
 
-PLACES_DETAIL_FIELDS_BASIC = set(
-    [
-        "address_component",
+PLACES_DETAIL_FIELDS_BASIC = {"address_component",
         "adr_address",
         "business_status",
         "formatted_address",
@@ -82,17 +76,11 @@
         "type",
         "url",
         "utc_offset",
-        "vicinity",
-    ]
-)
+        "vicinity",}
 
-PLACES_DETAIL_FIELDS_CONTACT = set(
-    ["formatted_phone_number", "international_phone_number", "opening_hours", "website"]
-)
+PLACES_DETAIL_FIELDS_CONTACT = {"formatted_phone_number", "international_phone_number", "opening_hours", "website"}
 
-PLACES_DETAIL_FIELDS_ATMOSPHERE = set(
-    ["price_level", "rating", "review", "user_ratings_total"]
-)
+PLACES_DETAIL_FIELDS_ATMOSPHERE = {"price_level", "rating", "review", "user_ratings_total"}
 
 PLACES_DETAIL_FIELDS = (
     PLACES_DETAIL_FIELDS_BASIC
@@ -658,3 +646,4 @@ def _autocomplete(
 
     url = "/maps/api/place/%sautocomplete/json" % url_part
     return client._request(url, params).get("predictions", [])
+    

tests/test_timezone.py

@@ -53,7 +53,7 @@ def test_los_angeles(self):
             responses.calls[0].request.url,
         )
 
-    class MockDatetime(object):
+    class MockDatetime:
         def now(self):
             return datetime.datetime.fromtimestamp(1608)