Add possibility to set AllowReauth in clientOpts (#162)

* Add possibility to set AllowReauth in clientOpts

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Remove setting AllowReauth in terraform auth config AuthInfo struct

Removed in favor of lines 161-162

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Set AllowReauth from *bool to bool to simplify the code and avoid nil pointer access

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Remove out-of-context comment about AllowReauth

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

Author: Lirt

openstack/clientconfig/requests.go

@@ -375,7 +375,7 @@ func AuthOptions(opts *ClientOpts) (*gophercloud.AuthOptions, error) {
 
 	// If cloud.AuthInfo is nil, then no cloud was specified.
 	if cloud.AuthInfo == nil {
-		// If opts.Auth is not nil, then try using the auth settings from it.
+		// If opts.AuthInfo is not nil, then try using the auth settings from it.
 		if opts.AuthInfo != nil {
 			cloud.AuthInfo = opts.AuthInfo
 		}
@@ -512,6 +512,7 @@ func v2auth(cloud *Cloud, opts *ClientOpts) (*gophercloud.AuthOptions, error) {
 		Password:         cloud.AuthInfo.Password,
 		TenantID:         cloud.AuthInfo.ProjectID,
 		TenantName:       cloud.AuthInfo.ProjectName,
+		AllowReauth:      cloud.AuthInfo.AllowReauth,
 	}
 
 	return ao, nil
@@ -684,6 +685,7 @@ func v3auth(cloud *Cloud, opts *ClientOpts) (*gophercloud.AuthOptions, error) {
 		ApplicationCredentialID:     cloud.AuthInfo.ApplicationCredentialID,
 		ApplicationCredentialName:   cloud.AuthInfo.ApplicationCredentialName,
 		ApplicationCredentialSecret: cloud.AuthInfo.ApplicationCredentialSecret,
+		AllowReauth:                 cloud.AuthInfo.AllowReauth,
 	}
 
 	// If an auth_type of "token" was specified, then make sure

openstack/clientconfig/results.go

@@ -126,6 +126,13 @@ type AuthInfo struct {
 	// DefaultDomain is the domain ID to fall back on if no other domain has
 	// been specified and a domain is required for scope.
 	DefaultDomain string `yaml:"default_domain,omitempty" json:"default_domain,omitempty"`
+
+	// AllowReauth should be set to true if you grant permission for Gophercloud to
+	// cache your credentials in memory, and to allow Gophercloud to attempt to
+	// re-authenticate automatically if/when your token expires.  If you set it to
+	// false, it will not cache these settings, but re-authentication will not be
+	// possible.  This setting defaults to false.
+	AllowReauth bool `yaml:"allow_reauth,omitempty" json:"allow_reauth,omitempty"`
 }
 
 // Region represents a region included as part of cloud in clouds.yaml