Make iteritems, iterkeys, itervalues, viewitems, viewkeys, viewvalues raise AttributeError

Author: grantjenks

HISTORY.rst

@@ -7,6 +7,15 @@ Sorted Containers Release History
 
 .. currentmodule:: sortedcontainers
 
+2.0.4 (2018-06-06)
+------------------
+
+**Bugfixes**
+
+* `SortedDict` methods `iterkeys`, `iteritems`, `itervalues`, `viewkeys`,
+  `viewitems`, and `viewvalues` are not implemented for Python 2. Attribute
+  lookup now raises :exc:`AttributeError`.
+
 2.0.3 (2018-05-31)
 ------------------
 

sortedcontainers/sorteddict.py

@@ -16,6 +16,7 @@
 
 """
 
+import sys
 import warnings
 from collections import ItemsView, KeysView, ValuesView, Sequence
 
@@ -357,6 +358,26 @@ def values(self):
         return SortedValuesView(self)
 
 
+    if sys.hexversion < 0x03000000:
+        def __make_raise_attributeerror(original, alternate):
+            message = (
+                'SortedDict.{original}() is not implemented.'
+                ' Use SortedDict.{alternate}() instead.'
+            ).format(original=original, alternate=alternate)
+            def method(self):
+                raise AttributeError(message)
+            method.__name__ = original
+            method.__doc__ = message
+            return property(method)
+
+        iteritems = __make_raise_attributeerror('iteritems', 'items')
+        iterkeys = __make_raise_attributeerror('iterkeys', 'keys')
+        itervalues = __make_raise_attributeerror('itervalues', 'values')
+        viewitems = __make_raise_attributeerror('viewitems', 'items')
+        viewkeys = __make_raise_attributeerror('viewkeys', 'keys')
+        viewvalues = __make_raise_attributeerror('viewvalues', 'values')
+
+
     class _NotGiven(object):
         # pylint: disable=too-few-public-methods
         def __repr__(self):

tests/test_coverage_sorteddict.py

@@ -215,6 +215,11 @@ def test_values():
     temp = SortedDict(mapping)
     assert list(temp.values()) == [pos for key, pos in mapping]
 
+def test_iterkeys():
+    temp = SortedDict()
+    with pytest.raises(AttributeError):
+        temp.iterkeys
+
 def test_notgiven():
     assert repr(SortedDict._SortedDict__not_given) == '<not-given>'