Merge pull request #236 from graphql-rust/no-skeptic

Migrate to 2018 edition and away from skeptic

Author: tomhoule

.travis.yml

@@ -15,14 +15,14 @@ before_script:
   - if [ "$TRAVIS_RUST_VERSION" = "beta" ]; then (sudo apt-get update) fi
   - if [ "$TRAVIS_RUST_VERSION" = "beta" ]; then (sudo apt-get install -y nodejs) fi
   - if [ "$TRAVIS_RUST_VERSION" = "beta" ]; then (npm i -g prettier) fi
-  - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (rustup component add rustfmt-preview clippy-preview) fi
+  - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (rustup component add rustfmt clippy) fi
   - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (rustup target add wasm32-unknown-unknown) fi
   - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (cargo install -f wasm-bindgen-cli) fi
 script:
   - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (cargo fmt --all -- --check) fi
   - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (cargo clippy -- -D warnings) fi
   - if [ "$TRAVIS_RUST_VERSION" = "beta" ]; then (prettier --debug-check -l './**/*.json' './**/*.graphql') fi
   - cargo test --all
-  # - cargo build --manifest-path=./examples/github/Cargo.toml
-  # - cargo build --manifest-path=./examples/web/Cargo.toml
+  - cargo build --manifest-path=./examples/github/Cargo.toml
+  - cargo build --manifest-path=./examples/web/Cargo.toml
   - if [ "$TRAVIS_RUST_VERSION" = "stable" ]; then (xvfb-run cargo test --manifest-path=./graphql_client_web/Cargo.toml --target wasm32-unknown-unknown) fi

CHANGELOG.md

@@ -7,7 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
-This release sees the switch to the Rust 2018 edition and is only compatible with Rust 1.31.0 and later.
+This release sees the switch to the Rust 2018 edition - it is
+only compatible with Rust 1.31.0 and later.
 
 ## 0.7.1
 

README.md

@@ -33,12 +33,8 @@ A typed GraphQL client library for Rust.
 
 - We now have everything we need to derive Rust types for our query. This is achieved through a procedural macro, as in the following snippet:
 
-  ```rust,skt-empty-main
-  extern crate serde;
-  #[macro_use]
-  extern crate serde_derive;
-  #[macro_use]
-  extern crate graphql_client;
+  ```rust
+  use graphql_client::GraphQLQuery;
 
   // The paths are relative to the directory where your `Cargo.toml` is located.
   // Both json and the GraphQL schema language are supported as sources for the schema
@@ -60,12 +56,7 @@ A typed GraphQL client library for Rust.
 
 * We now need to create the complete payload that we are going to send to the server. For convenience, the [GraphQLQuery trait](https://docs.rs/graphql_client/latest/graphql_client/trait.GraphQLQuery.html), is implemented for the struct under derive, so a complete query body can be created this way:
 
-  ```rust,skt-empty-main
-  extern crate failure;
-  #[macro_use]
-  extern crate graphql_client;
-  extern crate reqwest;
-
+  ```rust
   use graphql_client::{GraphQLQuery, Response};
 
   #[derive(GraphQLQuery)]
@@ -95,9 +86,8 @@ A typed GraphQL client library for Rust.
 
 The generated response types always derive `serde::Deserialize` but you may want to print them (`Debug`), compare them (`PartialEq`) or derive any other trait on it. You can achieve this with the `response_derives` option of the `graphql` attribute. Example:
 
-```rust,skt-empty-main
-#[macro_use]
-extern crate graphql_client;
+```rust
+use graphql_client::GraphQLQuery;
 
 #[derive(GraphQLQuery)]
 #[graphql(
@@ -117,9 +107,8 @@ The generated code will reference the scalar types as defined in the server sche
 The generated code has support for [`@deprecated`](http://facebook.github.io/graphql/June2018/#sec-Field-Deprecation)
 field annotations. You can configure how deprecations are handled via the `deprecated` argument in the `GraphQLQuery` derive:
 
-```rust,skt-empty-main
-#[macro_use]
-extern crate graphql_client;
+```rust
+use graphql_client::GraphQLQuery;
 
 #[derive(GraphQLQuery)]
 #[graphql(
@@ -145,15 +134,13 @@ You can write multiple operations in one query document (one `.graphql` file). Y
 
 Note that the struct and the operation in the GraphQL file *must* have the same name. We enforce this to make the generated code more predictable.
 
-```rust,skt-empty-main
-#[macro_use]
-extern crate graphql_client;
+```rust
+use graphql_client::GraphQLQuery;
 
 #[derive(GraphQLQuery)]
 #[graphql(
     schema_path = "tests/unions/union_schema.graphql",
     query_path = "tests/unions/union_query.graphql",
-    selected_operation = "SearchQuery"
 )]
 pub struct UnionQuery;
 ```

examples/example_module/Cargo.toml

@@ -2,6 +2,7 @@
 name = "graphql_query_github_example"
 version = "0.1.0"
 authors = ["Tom Houlé <tom@tomhoule.com>"]
+edition = "2018"
 
 [dependencies]
 failure = "*"

examples/example_module/src/custom_scalars.rs

@@ -1,21 +1,8 @@
-extern crate dotenv;
-extern crate envy;
-#[macro_use]
-extern crate failure;
-extern crate graphql_client;
-#[macro_use]
-extern crate log;
-extern crate env_logger;
-extern crate reqwest;
-extern crate serde;
-extern crate serde_json;
-#[macro_use]
-extern crate serde_derive;
-extern crate structopt;
-#[macro_use]
-extern crate prettytable;
-
+use failure::*;
 use graphql_client::*;
+use log::*;
+use prettytable::*;
+use serde::*;
 use structopt::StructOpt;
 
 type URI = String;
@@ -51,7 +38,7 @@ fn main() -> Result<(), failure::Error> {
     dotenv::dotenv().ok();
     env_logger::init();
 
-    let config: Env = envy::from_env()?;
+    let config: Env = envy::from_env().context("while reading from environment")?;
 
     let args = Command::from_args();
 

examples/example_module/src/lib.rs

@@ -11,10 +11,10 @@ lto = "thin"
 crate-type = ["cdylib"]
 
 [dependencies]
+graphql_client = { path = "../../graphql_client" }
 graphql_client_web = { path = "../../graphql_client_web" }
 wasm-bindgen = "0.2.12"
-serde = "1.0.67"
-serde_derive = "1.0.67"
+serde = { version = "1.0.67", features = ["derive"] }
 serde_json = "1.0.22"
 lazy_static = "1.0.1"
 js-sys = "0.3.6"

examples/github/Cargo.toml

@@ -1,13 +1,11 @@
 use futures::Future;
+use graphql_client_web::*;
 use lazy_static::*;
 use std::cell::RefCell;
 use std::sync::Mutex;
-
 use wasm_bindgen::prelude::*;
 use wasm_bindgen_futures::future_to_promise;
 
-use graphql_client_web::*;
-
 #[derive(GraphQLQuery)]
 #[graphql(
     schema_path = "schema.json",