chore: fix Rust 1.90 clippy

Author: hack3ric

src/bgp/mod.rs

@@ -260,7 +260,7 @@ impl<S: AsyncRead + AsyncWrite + Unpin> State<S> {
 }
 
 impl State<BufReader<TcpStream>> {
-  pub fn view(&self) -> StateView {
+  pub fn view(&self) -> StateView<'_> {
     match self {
       Idle => StateView::Idle,
       Connect => StateView::Connect,

src/bgp/msg.rs

@@ -547,7 +547,7 @@ impl UpdateMessage<'static> {
           }
 
           Some(PathAttr::Communities) => {
-            if len % 4 == 0 {
+            if len.is_multiple_of(4) {
               let mut opt_buf = vec![0; len.into()];
               pattrs_reader.read_exact(&mut opt_buf).await?;
               result.route_info.comm = opt_buf
@@ -561,7 +561,7 @@ impl UpdateMessage<'static> {
           }
 
           Some(PathAttr::ExtCommunities) => {
-            if len % 8 == 0 {
+            if len.is_multiple_of(8) {
               let mut opt_buf = vec![0; len.into()];
               pattrs_reader.read_exact(&mut opt_buf).await?;
               result.route_info.ext_comm = opt_buf
@@ -575,7 +575,7 @@ impl UpdateMessage<'static> {
           }
 
           Some(PathAttr::Ipv6ExtCommunities) => {
-            if len % 20 == 0 {
+            if len.is_multiple_of(20) {
               let mut opt_buf = vec![0; len.into()];
               pattrs_reader.read_exact(&mut opt_buf).await?;
               if let Some(comm) = opt_buf
@@ -595,7 +595,7 @@ impl UpdateMessage<'static> {
           }
 
           Some(PathAttr::LargeCommunities) => {
-            if len % 12 == 0 {
+            if len.is_multiple_of(12) {
               let mut opt_buf = vec![0; len.into()];
               pattrs_reader.read_exact(&mut opt_buf).await?;
               result.route_info.large_comm = opt_buf

src/ipc.rs

@@ -38,7 +38,7 @@ impl Session<BufReader<TcpStream>> {
   }
 }
 
-pub async fn get_states(path: impl AsRef<Path>, buf: &mut Vec<u8>) -> anyhow::Result<(RunArgs, StateView, Routes)> {
+pub async fn get_states(path: impl AsRef<Path>, buf: &mut Vec<u8>) -> anyhow::Result<(RunArgs, StateView<'_>, Routes)> {
   let mut stream = UnixStream::connect(path).await?;
   stream.read_to_end(buf).await?;
   let (config, buf) = postcard::take_from_bytes_cobs(buf)?;

src/kernel/linux/nft.rs

@@ -96,7 +96,7 @@ impl Nftables {
     Ok(apply_and_return_ruleset_async(n).await?)
   }
 
-  fn make_rule_handle(&self, handle: u32) -> schema::NfListObject {
+  fn make_rule_handle(&self, handle: u32) -> schema::NfListObject<'_> {
     schema::NfListObject::Rule(schema::Rule {
       family: types::NfFamily::INet,
       table: self.table.clone(),
@@ -598,11 +598,11 @@ impl Ops<Numeric> {
             }
             *x = y;
             return true;
-          } else if let Some(r2) = &r2 {
-            if let Some(y) = x.clone().intersect(r2.clone()) {
-              *x = y;
-              return true;
-            }
+          } else if let Some(r2) = &r2
+            && let Some(y) = x.clone().intersect(r2.clone())
+          {
+            *x = y;
+            return true;
           }
           false
         });

src/util.rs

@@ -155,7 +155,7 @@ impl TruthTable {
     self
   }
 
-  pub fn possible_values_masked(&self) -> Cow<BTreeSet<u64>> {
+  pub fn possible_values_masked(&self) -> Cow<'_, BTreeSet<u64>> {
     if self.inv {
       Cow::Owned(
         iter_masked(self.mask)
@@ -169,7 +169,7 @@ impl TruthTable {
     }
   }
 
-  pub fn shrink(&self, other_mask: u64) -> Cow<Self> {
+  pub fn shrink(&self, other_mask: u64) -> Cow<'_, Self> {
     let mask = self.mask & other_mask;
     if mask == self.mask {
       Cow::Borrowed(self)
@@ -178,7 +178,7 @@ impl TruthTable {
     }
   }
 
-  pub fn expand(&self, other_mask: u64) -> Cow<Self> {
+  pub fn expand(&self, other_mask: u64) -> Cow<'_, Self> {
     let mask = self.mask | other_mask;
     if mask == self.mask {
       Cow::Borrowed(self)
@@ -193,7 +193,7 @@ impl TruthTable {
     }
   }
 
-  fn expand_set(&self, other_mask: u64) -> Cow<BTreeSet<u64>> {
+  fn expand_set(&self, other_mask: u64) -> Cow<'_, BTreeSet<u64>> {
     match self.expand(other_mask) {
       Cow::Borrowed(x) => Cow::Borrowed(&x.truth),
       Cow::Owned(x) => Cow::Owned(x.truth),