correct check for priority and status value in array

hackzilla · hackzilla · commit 5a1a2b0135cf · 2016-07-20T00:33:49.000+01:00
diff --git a/Entity/Traits/TicketMessageTrait.php b/Entity/Traits/TicketMessageTrait.php
@@ -96,7 +96,7 @@ public function getStatus()
      */
     public function getStatusString()
     {
-        if (in_array($this->status, TicketMessageInterface::STATUSES)) {
+        if (!empty(TicketMessageInterface::STATUSES[$this->status])) {
             return TicketMessageInterface::STATUSES[$this->status];
         }
 
@@ -152,7 +152,7 @@ public function getPriority()
      */
     public function getPriorityString()
     {
-        if (in_array($this->priority, TicketMessageInterface::PRIORITIES)) {
+        if (!empty(TicketMessageInterface::PRIORITIES[$this->priority])) {
             return TicketMessageInterface::PRIORITIES[$this->priority];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function getStatus()`
`96`	`96`	`*/`
`97`	`97`	`public function getStatusString()`
`98`	`98`	`{`
`99`		`- if (in_array($this->status, TicketMessageInterface::STATUSES)) {`
	`99`	`+ if (!empty(TicketMessageInterface::STATUSES[$this->status])) {`
`100`	`100`	`return TicketMessageInterface::STATUSES[$this->status];`
`101`	`101`	`}`
`102`	`102`
`@@ -152,7 +152,7 @@ public function getPriority()`
`152`	`152`	`*/`
`153`	`153`	`public function getPriorityString()`
`154`	`154`	`{`
`155`		`- if (in_array($this->priority, TicketMessageInterface::PRIORITIES)) {`
	`155`	`+ if (!empty(TicketMessageInterface::PRIORITIES[$this->priority])) {`
`156`	`156`	`return TicketMessageInterface::PRIORITIES[$this->priority];`
`157`	`157`	`}`
`158`	`158`