Skip to content

Commit 88c1a0e

Browse files
committed
minor #172 Update README.md (phansys)
This PR was merged into the 3.x branch. Discussion ---------- |Q |A | |--- |---| |Branch |3.x| |Bug fix? |no | |New feature? |no | |BC breaks? |no | |Deprecations?|no | |Tests pass? |yes| |Fixed tickets|n/a| |License |MIT| |Doc PR |n/a| Commits ------- ec63429 Update `README.md`
2 parents 98dcac7 + ec63429 commit 88c1a0e

5 files changed

Lines changed: 24 additions & 13 deletions

File tree

.php_cs.dist

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ if (\class_exists(PhpCsFixer\Config::class, false)) {
1515
->setUsingCache(true)
1616
->setRiskyAllowed(true)
1717
->setRules([
18+
'@PHP56Migration' => true,
19+
'@PHP56Migration:risky' => true,
20+
'@PHPUnit57Migration:risky' => true,
1821
'@Symfony' => true,
1922
'@Symfony:risky' => true,
2023
'array_syntax' => ['syntax' => 'short'],
@@ -47,6 +50,7 @@ if (\class_exists(PhpCsFixer\Config::class, false)) {
4750
'phpdoc_order' => true,
4851
'single_line_throw' => false,
4952
'static_lambda' => true,
53+
'strict_param' => true,
5054
])
5155
->setFinder(
5256
PhpCsFixer\Finder::create()->exclude(['Tests/Functional/cache'])->in(__DIR__)
@@ -57,11 +61,18 @@ if (\class_exists(PhpCsFixer\Config::class, false)) {
5761
return Symfony\CS\Config\Config::create()
5862
->setUsingCache(true)
5963
->fixers([
64+
'combine_consecutive_unsets',
65+
'ereg_to_preg',
6066
'header_comment' => $header,
6167
'newline_after_open_tag',
6268
'ordered_use',
6369
'php_unit_construct',
70+
'php_unit_dedicate_assert',
71+
'php_unit_strict',
72+
'phpdoc_order',
6473
'short_array_syntax',
74+
'short_echo_tag',
75+
'strict_param',
6576
])
6677
->finder(
6778
Symfony\CS\Finder\DefaultFinder::create()

Entity/Traits/TicketMessageTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public function setStatus($status)
8080
*/
8181
public function setStatusString($status)
8282
{
83-
$status = array_search(strtolower($status), TicketMessageInterface::STATUSES);
83+
$status = array_search(strtolower($status), TicketMessageInterface::STATUSES, true);
8484

8585
if ($status > 0) {
8686
$this->setStatus($status);
@@ -136,7 +136,7 @@ public function setPriority($priority)
136136
*/
137137
public function setPriorityString($priority)
138138
{
139-
$priority = array_search(strtolower($priority), TicketMessageInterface::PRIORITIES);
139+
$priority = array_search(strtolower($priority), TicketMessageInterface::PRIORITIES, true);
140140

141141
if ($priority > 0) {
142142
$this->setPriority($priority);

Entity/Traits/TicketTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public function setStatus($status)
9999
*/
100100
public function setStatusString($status)
101101
{
102-
$status = array_search(strtolower($status), TicketMessageInterface::STATUSES);
102+
$status = array_search(strtolower($status), TicketMessageInterface::STATUSES, true);
103103

104104
if ($status > 0) {
105105
$this->setStatus($status);
@@ -155,7 +155,7 @@ public function setPriority($priority)
155155
*/
156156
public function setPriorityString($priority)
157157
{
158-
$priority = array_search(strtolower($priority), TicketMessageInterface::PRIORITIES);
158+
$priority = array_search(strtolower($priority), TicketMessageInterface::PRIORITIES, true);
159159

160160
if ($priority > 0) {
161161
$this->setPriority($priority);

Manager/TicketManager.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ public function getTicketStatus($statusStr)
307307
}
308308
}
309309

310-
return array_search($statusStr, $statuses);
310+
return array_search($statusStr, $statuses, true);
311311
}
312312

313313
/**
@@ -329,6 +329,6 @@ public function getTicketPriority($priorityStr)
329329
}
330330
}
331331

332-
return array_search($priorityStr, $priorities);
332+
return array_search($priorityStr, $priorities, true);
333333
}
334334
}

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Available translations for:
1919

2020
## Requirements
2121

22-
* PHP >= 5.6
22+
* PHP ^5.6\|^7.0
2323
* [Symfony][1] ^2.8|^3.4|^4.0
2424
* [Knp Paginator bundle][2]
2525

@@ -30,12 +30,12 @@ Available translations for:
3030

3131
## Version Matrix
3232

33-
| Ticket Bundle | Symfony | PHP |
34-
| --------------| ---------------- | ----- |
35-
| [3.x][6] | ^2.8\|^3.4\|^4.0 | >=5.6 |
36-
| [2.x][7] | ^2.7\|^3.4 | >=5.3 |
37-
| [1.x][8] | ^2.3 | >=5.3 |
38-
| [0.x][9] | ^2.3 | >=5.3 |
33+
| Ticket Bundle | Symfony | PHP |
34+
| --------------| ---------------- | ---------- |
35+
| [3.x][6] | ^2.8\|^3.4\|^4.0 | ^5.6\|^7.0 |
36+
| [2.x][7] | ^2.7\|^3.4 | ^5.3\|^7.0 |
37+
| [1.x][8] | ^2.3 | ^5.3\|^7.0 |
38+
| [0.x][9] | ^2.3 | ^5.3\|^7.0 |
3939

4040
## Demo
4141

0 commit comments

Comments
 (0)