Merge pull request #15 from srbmaury/master

fixed error in history

Author: harsh98trivedi

calc.js

@@ -10,6 +10,7 @@ document.getElementById("answer").readOnly = true; //set this attribute in Html
 let screen = document.getElementById("answer");
 buttons = document.querySelectorAll("button");
 let screenValue = "";
+let maxItems = 6;
 for (item of buttons) {
   item.addEventListener("click", (e) => {
     buttonText = e.target.innerText;
@@ -102,6 +103,12 @@ window.onerror = function () {
 window.onBracketMultiplication = function () {
   screenValue = addStr(screen.value, screen.value.indexOf("("), "*");
   screen.value = eval(screenValue);
+  let calcHistory = JSON.parse(localStorage.getItem("calcHistory")) || [];
+  if(calcHistory.length >= maxItems){
+      calcHistory.shift();
+  }
+  calcHistory.push({screenValue, result : screen.value});
+  localStorage.setItem("calcHistory", JSON.stringify(calcHistory));
 };
 
 function addStr(str, index, stringToAdd) {
@@ -120,6 +127,12 @@ function checkForBracketMulti() {
     return;
   } else {
     screen.value = eval(screenValue);
+    let calcHistory = JSON.parse(localStorage.getItem("calcHistory")) || [];
+    if(calcHistory.length >= maxItems){
+        calcHistory.shift();
+    }
+    calcHistory.push({screenValue, result : screen.value});
+    localStorage.setItem("calcHistory", JSON.stringify(calcHistory));
   }
   flag = 1;
 }

hist.js

@@ -18,13 +18,13 @@ function showHistory() {
         historyItem.style.fontSize = '30px';
         history.appendChild(historyItem);
     } else {
-        for (let index = 0; index < len; index++) {
+        for (let index = len-1; index >=0; index--) {
             const element = calcHistory[index];
             let historyItem = document.createElement('div');
             historyItem.className = 'historyelement';
             historyItem.innerHTML = `${element.screenValue} =  ${element.result}`;
             history.appendChild(historyItem);
-            if (index < len - 1) history.appendChild(document.createElement('hr'));
+            if (index > 0) history.appendChild(document.createElement('hr'));
         }
     }
     history.style.display = 'block';