Skip to content

Commit c0c75df

Browse files
committed
chore: fix lint issues
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
1 parent e3e891b commit c0c75df

12 files changed

Lines changed: 58 additions & 33 deletions

File tree

.github/dependabot.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ updates:
77
interval: weekly
88
day: friday
99
time: "04:00"
10+
cooldown:
11+
default-days: 7
1012
groups:
1113
docker-dependencies:
1214
patterns:
@@ -21,6 +23,8 @@ updates:
2123
interval: weekly
2224
day: friday
2325
time: "04:00"
26+
cooldown:
27+
default-days: 7
2428
groups:
2529
github-actions-dependencies:
2630
patterns:
@@ -33,6 +37,8 @@ updates:
3337
interval: weekly
3438
day: friday
3539
time: "04:00"
40+
cooldown:
41+
default-days: 7
3642
groups:
3743
npm-dependencies:
3844
patterns:
@@ -45,3 +51,5 @@ updates:
4551
interval: weekly
4652
day: friday
4753
time: "04:00"
54+
cooldown:
55+
default-days: 7

.github/workflows/need-fix-to-issue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
6767
**Tips:**
6868
69-
It is recommanded to add this trigger for this workflow:
69+
It is recommended to add this trigger for this workflow:
7070
7171
```yaml
7272
workflow_dispatch:

.github/workflows/semantic-pull-request.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
## Overview
2525

26-
Workflow to ensure Pull Request provides semantic versionning assets:
26+
Workflow to ensure Pull Request provides semantic versioning assets:
2727

2828
- "Squash and merge" Pull Request strategy provides a valid commit message.
2929
Check that the title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification.

.github/workflows/semantic-pull-request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Workflow to ensure Pull Request provides semantic versionning assets:
1+
# Workflow to ensure Pull Request provides semantic versioning assets:
22
#
33
# - "Squash and merge" Pull Request strategy provides a valid commit message.
44
# Check that the title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification.

actions/checkout/action.yml

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,35 @@ runs:
3333
using: "composite"
3434
steps:
3535
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
36-
if: github.event_name == 'issue_comment'
36+
if: github.event_name == 'issue_comment' && inputs.persist-credentials == 'true'
3737
with:
3838
ref: refs/pull/${{ github.event.issue.number }}/head
3939
fetch-depth: ${{ inputs.fetch-depth }}
4040
lfs: ${{ inputs.lfs }}
4141
token: ${{ inputs.token || github.token }}
42-
persist-credentials: ${{ inputs.persist-credentials == 'true' && 'true' || 'false' }}
42+
persist-credentials: true
4343

4444
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
45-
if: github.event_name != 'issue_comment'
45+
if: github.event_name == 'issue_comment' && inputs.persist-credentials != 'true'
46+
with:
47+
ref: refs/pull/${{ github.event.issue.number }}/head
48+
fetch-depth: ${{ inputs.fetch-depth }}
49+
lfs: ${{ inputs.lfs }}
50+
token: ${{ inputs.token || github.token }}
51+
persist-credentials: false
52+
53+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
54+
if: github.event_name != 'issue_comment' && inputs.persist-credentials == 'true'
55+
with:
56+
fetch-depth: ${{ inputs.fetch-depth }}
57+
lfs: ${{ inputs.lfs }}
58+
token: ${{ inputs.token || github.token }}
59+
persist-credentials: true
60+
61+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
62+
if: github.event_name != 'issue_comment' && inputs.persist-credentials != 'true'
4663
with:
4764
fetch-depth: ${{ inputs.fetch-depth }}
4865
lfs: ${{ inputs.lfs }}
4966
token: ${{ inputs.token || github.token }}
50-
persist-credentials: ${{ inputs.persist-credentials == 'true' && 'true' || 'false' }}
67+
persist-credentials: false

actions/create-and-merge-pull-request/action.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,16 @@ runs:
6767
with:
6868
github-token: ${{ inputs.github-token }}
6969
script: |
70-
let attemps = 0;
71-
const maxAttemps = 10;
70+
let attempts = 0;
71+
const maxAttempts = 10;
7272
7373
const pullNumberRaw = process.env.PULL_REQUEST_NUMBER ?? '';
7474
if (!/^[0-9]+$/.test(pullNumberRaw)) {
7575
throw new Error(`Invalid pull request number: ${pullNumberRaw}`);
7676
}
7777
const pullNumber = Number.parseInt(pullNumberRaw, 10);
7878
79-
while (attemps < maxAttemps) {
79+
while (attempts < maxAttempts) {
8080
const { data: { mergeable, mergeable_state } } = await github.rest.pulls.get({
8181
owner: context.repo.owner,
8282
repo: context.repo.repo,
@@ -91,7 +91,7 @@ runs:
9191
core.debug(`Pull request is not mergeable, mergeable_state: ${mergeable_state}`);
9292
9393
await new Promise(resolve => setTimeout(resolve, 5000));
94-
attemps++;
94+
attempts++;
9595
}
9696
9797
core.error('Pull request is not mergeable');
@@ -110,11 +110,11 @@ runs:
110110
exit 1
111111
fi
112112
113-
ATTEMPS=0
114-
MAX_ATTEMPS=10
113+
ATTEMPTS=0
114+
MAX_ATTEMPTS=10
115115
REQUIRED_WORKFLOWS_ERROR="Required workflow"
116116
117-
while [ $ATTEMPS -lt $MAX_ATTEMPS ]; do
117+
while [ $ATTEMPTS -lt $MAX_ATTEMPTS ]; do
118118
echo "::debug::Merging pull request #${PULL_REQUEST_NUMBER} for repository ${{ github.repository }}..."
119119
MERGE_OUTPUTS=$(gh pr merge -R "${{ github.repository }}" --rebase --admin "${PULL_REQUEST_NUMBER}" 2>&1)
120120
MERGE_EXIT_CODE=$?
@@ -132,8 +132,8 @@ runs:
132132
133133
echo "::debug::Pull request is not mergeable yet because some of required workflow check issues, retrying in 5 seconds..."
134134
sleep 5
135-
ATTEMPS=$((ATTEMPS+1))
135+
ATTEMPTS=$((ATTEMPTS+1))
136136
done
137137
138-
echo "::error::Failed to merge pull request after $MAX_ATTEMPS attemps: $MERGE_OUTPUTS"
138+
echo "::error::Failed to merge pull request after $MAX_ATTEMPTS attempts: $MERGE_OUTPUTS"
139139
exit 1

actions/get-github-actions-bot-user/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424

2525
## Overview
2626

27-
Action to get the GitHub Actions bot user informations.
28-
Usefull to commit, comment, etc.
27+
Action to get the GitHub Actions bot user information.
28+
Useful to commit, comment, etc.
2929

3030
<!-- overview:end -->
3131

actions/get-github-actions-bot-user/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: "Get GitHub Actions bot user"
22
description: |
3-
Action to get the GitHub Actions bot user informations.
4-
Usefull to commit, comment, etc.
3+
Action to get the GitHub Actions bot user information.
4+
Useful to commit, comment, etc.
55
author: hoverkraft
66
branding:
77
icon: user-check
@@ -20,4 +20,4 @@ runs:
2020
steps:
2121
- id: get-bot-user
2222
shell: bash
23-
run: 'echo "Get GitHub Actions bot user informations"'
23+
run: 'echo "Get GitHub Actions bot user information"'

actions/get-matrix-outputs/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<!-- header:start -->
22

3-
# ![Icon](data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0IiBmaWxsPSJub25lIiBzdHJva2U9ImN1cnJlbnRDb2xvciIgc3Ryb2tlLXdpZHRoPSIyIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiIGNsYXNzPSJmZWF0aGVyIGZlYXRoZXItZG93bmxvYWQtY2xvdWQiIGNvbG9yPSJibHVlIj48cG9seWxpbmUgcG9pbnRzPSI4IDE3IDEyIDIxIDE2IDE3Ij48L3BvbHlsaW5lPjxsaW5lIHgxPSIxMiIgeTE9IjEyIiB4Mj0iMTIiIHkyPSIyMSI+PC9saW5lPjxwYXRoIGQ9Ik0yMC44OCAxOC4wOUE1IDUgMCAwIDAgMTggOWgtMS4yNkE4IDggMCAxIDAgMyAxNi4yOSI+PC9wYXRoPjwvc3ZnPg==) GitHub Action: Get matrix ouput
3+
# ![Icon](data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0IiBmaWxsPSJub25lIiBzdHJva2U9ImN1cnJlbnRDb2xvciIgc3Ryb2tlLXdpZHRoPSIyIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiIGNsYXNzPSJmZWF0aGVyIGZlYXRoZXItZG93bmxvYWQtY2xvdWQiIGNvbG9yPSJibHVlIj48cG9seWxpbmUgcG9pbnRzPSI4IDE3IDEyIDIxIDE2IDE3Ij48L3BvbHlsaW5lPjxsaW5lIHgxPSIxMiIgeTE9IjEyIiB4Mj0iMTIiIHkyPSIyMSI+PC9saW5lPjxwYXRoIGQ9Ik0yMC44OCAxOC4wOUE1IDUgMCAwIDAgMTggOWgtMS4yNkE4IDggMCAxIDAgMyAxNi4yOSI+PC9wYXRoPjwvc3ZnPg==) GitHub Action: Get matrix outputs
44

55
<div align="center">
6-
<img src="../../.github/logo.svg" width="60px" align="center" alt="Get matrix ouput" />
6+
<img src="../../.github/logo.svg" width="60px" align="center" alt="Get matrix outputs" />
77
</div>
88

99
---
@@ -12,7 +12,7 @@
1212

1313
<!-- badges:start -->
1414

15-
[![Marketplace](https://img.shields.io/badge/Marketplace-get--matrix--ouput-blue?logo=github-actions)](https://github.com/marketplace/actions/get-matrix-ouput)
15+
[![Marketplace](https://img.shields.io/badge/Marketplace-get--matrix--outputs-blue?logo=github-actions)](https://github.com/marketplace/actions/get-matrix-outputs)
1616
[![Release](https://img.shields.io/github/v/release/hoverkraft-tech/ci-github-common)](https://github.com/hoverkraft-tech/ci-github-common/releases)
1717
[![License](https://img.shields.io/github/license/hoverkraft-tech/ci-github-common)](http://choosealicense.com/licenses/mit/)
1818
[![Stars](https://img.shields.io/github/stars/hoverkraft-tech/ci-github-common?style=social)](https://img.shields.io/github/stars/hoverkraft-tech/ci-github-common?style=social)
@@ -24,7 +24,7 @@
2424

2525
## Overview
2626

27-
Download matrix ouputs from artifacts, because GitHub Action does not handle job outputs for matrix.
27+
Download matrix outputs from artifacts, because GitHub Action does not handle job outputs for matrix.
2828
Workaround for <https://github.com/orgs/community/discussions/26639>.
2929

3030
<!-- overview:end -->

actions/get-matrix-outputs/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
name: "Get matrix ouput"
1+
name: "Get matrix outputs"
22
description: |
3-
Download matrix ouputs from artifacts, because GitHub Action does not handle job outputs for matrix.
3+
Download matrix outputs from artifacts, because GitHub Action does not handle job outputs for matrix.
44
Workaround for https://github.com/orgs/community/discussions/26639.
55
author: hoverkraft
66
branding:

0 commit comments

Comments
 (0)